Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parent Class Loaded By Scripting tool #90

Closed
wheeller123 opened this issue Jun 15, 2022 · 2 comments
Closed

Parent Class Loaded By Scripting tool #90

wheeller123 opened this issue Jun 15, 2022 · 2 comments
Labels
Affects Scripted Code Will change how generated code looks scope: documentation Improvements or additions to documentation

Comments

@wheeller123
Copy link

wheeller123 commented Jun 15, 2022 •
edited by ni-github-admins
Loading

When using the Code Generator to create a server from proto file, the Run Service.vi is created with the parent class constant instead of the child class for the service. I think this will confuse people at the beginning using the Code Generator

image

AB#2972877
@eyesonvis
Copy link
Collaborator

Definitely confusing, but perhaps could be addressed with better documentation (e.g., a comment on the diagram with clear instructions) and a different icon for the service base class.

@eyesonvis eyesonvis added scope: documentation Improvements or additions to documentation Affects Scripted Code Will change how generated code looks labels Aug 31, 2022
@jasonmreding
Copy link
Collaborator

This should be addressed with #399 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Affects Scripted Code Will change how generated code looks scope: documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wheeller123 @eyesonvis @jasonmreding