Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC Server halted by invalid Enum received from Client #328

Closed
BShermanator opened this issue Dec 6, 2023 · 4 comments
Closed

gRPC Server halted by invalid Enum received from Client #328

BShermanator opened this issue Dec 6, 2023 · 4 comments
Assignees

Comments

@BShermanator
Copy link
Contributor

BShermanator commented Dec 6, 2023

If a user sends an enum of 0 indicating it is unspecified, a gRPC server is halted by a modal error window.

I do not think this is expected since there is comment, saying we do not want the server to stop.

image

AB#2597172

@pratheekshasn
Copy link
Collaborator

@BShermanator
The set of values in the enum must contain a 0 (according to the documentation here). The error you have mentioned above gets thrown only when the user passes a value that is not defined in the proto file with which the client/server code is generated.

Could you please attach a project from which I can reproduce this issue?

@BShermanator
Copy link
Contributor Author

@pratheekshasn - I was aware of an enum containing 0, but my understanding that the error case occurred if I sent 0 was incorrect. The new insight is helpful because I must be sending a number other than 0.

However, if a client does send an enum that is not define in the proto file, the LV gRPC server stops because of the modal error dialog. The error should be handled in a way that does not halt the servers execution. Do you agree or is there another piece of information I am missing?

@pratheekshasn
Copy link
Collaborator

Yes, I agree. I have created a PR for this issue.

@pratheekshasn
Copy link
Collaborator

This has been fixed by PR #334. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants