-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gRPC Server halted by invalid Enum received from Client #328
Comments
@BShermanator Could you please attach a project from which I can reproduce this issue? |
@pratheekshasn - I was aware of an enum containing 0, but my understanding that the error case occurred if I sent 0 was incorrect. The new insight is helpful because I must be sending a number other than 0. However, if a client does send an enum that is not define in the proto file, the LV gRPC server stops because of the modal error dialog. The error should be handled in a way that does not halt the servers execution. Do you agree or is there another piece of information I am missing? |
Yes, I agree. I have created a PR for this issue. |
This has been fixed by PR #334. Closing this issue. |
If a user sends an enum of 0 indicating it is unspecified, a gRPC server is halted by a modal error window.
I do not think this is expected since there is comment, saying we do not want the server to stop.
AB#2597172
The text was updated successfully, but these errors were encountered: