Upgrade to Angular 19 changes Subscriptions to RxMethodRef

[leomayer]

Which @ngrx/* package(s) are the source of the bug?

signals

Minimal reproduction of the bug/regression with instructions

I have defined in my signalStore

withChatStates(),
withMethods((state) => {
   startDelay4NewChatSession: rxMethod<boolean>(
				pipe(
					filter((startDelay) => startDelay),
					delay(5000),
					tap(() => state.ready4NewContext()),
				),

and

export function withChatStates(){
...
	withComputed((state) => {
			return {
				isDelayInit: computed(() => state.sessionState() === 'delayInit'),

and in a component

 lstOfSubscriptions:Subscription = autoSubscriptionsUnsubscribe();

ngOnInit():{
   this.lstOfSubscriptions.add(this.chatStore.startDelay4NewChatSession(this.chatStore.isDelayInit))

Expected behavior

With Angular 18 this code works exactly as expected. I add this to rxMethod to my list and it will unsubcribe automatically.

After upgrading I get the error message:

 [ERROR] TS2345: Argument of type 'RxMethodRef' is not assignable to parameter of type 'TeardownLogic'. [plugin angular-compiler]

[UPDATE]: I've figured out that the Subscription is causing the problem. Therefore just a question remains:

Instead of the automatic unsubscribe should I use now a destroy? Do they have the same effect?

BTW: RxMethodRef is not exported

Versions of NgRx, Angular, Node, affected browser(s) and operating system(s)

"@ngrx/signals": "^19.0.0"
"@angular/compiler": "^19.0.5",
"@angular/core": "^19.0.5",
Linux

Other information

No response

I would be willing to submit a PR to fix this issue

• Yes
• No

[rainerhahnekamp]

@leomayer it would help us a lot of you can use our provided stackblitz to reproduce it.

[markostanimirovic]

In v19, rxMethod.unsubscribe is renamed to rxMethod.destroy. Read more in the migration guide: https://ngrx.io/guide/migration/v19#rename-rxmethodunsubscribe-to-rxmethoddestroy

If you move this.chatStore.startDelay4NewChatSession(this.chatStore.isDelayInit) from ngOnInit to constructor or provide injector as the second argument:

class MyComponent implements OnInit {
  readonly injector = inject(Injector);


  ngOnInit() {
    this.chatStore.startDelay4NewChatSession(
      this.chatStore.isDelayInit,
      { injector: this.injector }
    );
  }
}

There is no need to do manual cleanup because automatic cleanup will happen on component destruction.

Read rxMethod docs for more info: https://ngrx.io/guide/signals/rxjs-integration#rxmethod

[leomayer]

@markostanimirovic: ahhh... thx... That tiny bit of information I didn't conclude from the 'Manual cleanup' section

https://ngrx.io/guide/signals/rxjs-integration#manual-cleanup

[leomayer]

@rainerhahnekamp I've missed that the unsubscribe is now a destroy and therefore won't work any longer in the given context. A list of subscriptions could be unsubscribed at once. But anyway this is now clarified _/_