Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.33 meta tasks #1399

Closed
6 tasks done
callahad opened this issue Aug 22, 2024 · 10 comments
Closed
6 tasks done

Release 1.33 meta tasks #1399

callahad opened this issue Aug 22, 2024 · 10 comments
Milestone

Comments

@callahad
Copy link
Collaborator

callahad commented Aug 22, 2024

  • Review all open PRs
  • Ensure changelog is up to date, select shortlist of user-facing changes to highlight (@avahahn + @ac000)
  • Write up user-facing highlights (@Jcahilltorre)
  • Review the commits immediately prior to 1.32 to see if there are any steps we might miss (@ac000)
  • Update wasmtime version for the wasm-wasi-component language module (@avahahn)
  • Re-review the release checklist (@callahad)

...and then hand it off to SysEng to make the release :)

@callahad callahad added this to the 1.33 milestone Aug 22, 2024
@Jcahilltorre
Copy link
Contributor

Where can I see the list of items to be highlighted on this release?

@callahad
Copy link
Collaborator Author

Those will be plucked out by @avahahn and @ac000 as part of the bullet immediately above the handoff task :)

@ac000

This comment was marked as outdated.

@ac000
Copy link
Member

ac000 commented Aug 22, 2024

OK, forget the previous comment.

To keep just one source of truth (docs/changes.xml/CHANGES), I've started #1401

@ac000
Copy link
Member

ac000 commented Aug 22, 2024

As well as the changelog, I think we should start providing the output of git shortlog ... as the Git (and other projects do), e.g https://lore.kernel.org/git/[email protected]/

And let's not forget to highlight our external contributors... currently

Alejandro Colomar (12)
Arjun (15)
Costas Drongos (1)
Gourav (2)
Remi Collet (1)
dependabot[bot] (5)

I think we can ignore dependabot!

@ac000
Copy link
Member

ac000 commented Aug 26, 2024

We should probably give Arjun (@pkillarjun) special mention for his fuzzing work...

@ac000
Copy link
Member

ac000 commented Aug 27, 2024

In terms of what we need to commit before a release, looking back over the last few releases, there's no standard order of things, but I believe it should basically be these three commits

  1. Generate dockerfiles (well that's what it was called ace553d) Update dockerfiles
  2. Update changes.xml
  3. Generate new CHANGES files

That last commit is what gets tagged as the new release.

Except that the dockerfile thing throws a slight fly in the ointment due to changes like

-    && git clone --depth 1 -b 1.31.1-1 https://github.com/nginx/unit \
+    && git clone --depth 1 -b 1.32.0-1 https://github.com/nginx/unit \

Which means there is a window (albeit small(ish)) where these won't work until the -1 tag is created.

It also looks like we can just get rid of .hgtags, that hasn't been updated since 1.31.1

@Jcahilltorre
Copy link
Contributor

I will open a PR with the skeleton file for the news page

@ac000
Copy link
Member

ac000 commented Aug 27, 2024

I have created a draft of the 1.33.0 announce email (sent to the Unit mailing list), somewhat inspired by git's announce emails.

If anyone notices their favourite feature missing, let me know, or even better, send text!

@Jcahilltorre Feel free to lift bits out of there for the website.

@ac000
Copy link
Member

ac000 commented Aug 28, 2024

Hey folks, still a few outstanding things before we can release...

@ac000 ac000 closed this as completed Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants