Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nginx go client and prometheus common libs #6032

Closed
vepatel opened this issue Jul 17, 2024 · 3 comments
Closed

Update nginx go client and prometheus common libs #6032

vepatel opened this issue Jul 17, 2024 · 3 comments
Assignees
@vepatel
Labels
proposal An issue that proposes a feature request

Comments

@vepatel
Copy link
Contributor

vepatel commented Jul 17, 2024

The most recent releases of https://github.com/nginxinc/nginx-plus-go-client and https://github.com/prometheus/common have breaking changes as a NIC dependency and require manual changes:
dependabot PR: #6028
@vepatel vepatel added proposal An issue that proposes a feature request ready for refinement An issue that was triaged and it is ready to be refined labels Jul 17, 2024
@github-actions GitHub Actions
Copy link

Hi @vepatel thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!

@vepatel vepatel linked a pull request Jul 24, 2024 that will close this issue
replace promlog with go-kit #6052
Merged
6 tasks
@vepatel vepatel removed the ready for refinement An issue that was triaged and it is ready to be refined label Jul 24, 2024
@danielnginx danielnginx reopened this Jul 24, 2024
@danielnginx danielnginx assigned vepatel and unassigned pdabelf5 Jul 24, 2024
@vepatel
Copy link
Contributor Author

vepatel commented Jul 30, 2024

to be looked at after k8s 1.31 release: #6074

@vepatel
Copy link
Contributor Author

vepatel commented Aug 14, 2024

closing in favour of #6186

@vepatel vepatel closed this as completed Aug 14, 2024
@vepatel vepatel removed a link to a pull request Aug 14, 2024
replace promlog with go-kit #6052
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vepatel vepatel

Labels
proposal An issue that proposes a feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vepatel @danielnginx @pdabelf5