Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.conf not properly formatted as of 3.4.3 #5184

Closed
jasonwilliams14 opened this issue Feb 28, 2024 · 4 comments
Closed

.conf not properly formatted as of 3.4.3 #5184

jasonwilliams14 opened this issue Feb 28, 2024 · 4 comments
Labels
bug An issue reporting a potential bug
Milestone

Comments

@jasonwilliams14
Copy link
Contributor

jasonwilliams14 commented Feb 28, 2024

Describe the bug
The underlying nginx.conf is not being properly generated. Directives that should be on their own line are not which makes reading the .conf difficult.

To Reproduce
Install 3.4.3, add several resources and review the generated .conf

Latest results as of today using 3.4.3 (using prebuilt image and built my own)

upstream vs_cafe-test {
    zone vs_cafe_test 512k;random two least_conn;

In the above, random two least_conn should and needs to be on its own line.

Expected behavior
See above.

Your environment

Tested with Kind and K3D, version 3.4.3 of NIC.

Copy link

Hi @jasonwilliams14 thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!

@jjngx jjngx added the bug An issue reporting a potential bug label Feb 28, 2024
@jjngx jjngx added this to the v3.5.0 milestone Feb 28, 2024
@j1m-ryan
Copy link

This is fixed on main but wasn't cherry picked into v3.4.3

@vepatel
Copy link
Contributor

vepatel commented Mar 6, 2024

@jasonwilliams14 duplicate of #4951

@jjngx
Copy link
Contributor

jjngx commented Mar 25, 2024

fix for this will land in release v3.5.0

@jjngx jjngx closed this as completed Mar 25, 2024
@jjngx jjngx closed this as not planned Won't fix, can't repro, duplicate, stale Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
None yet
Development

No branches or pull requests

4 participants