Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate TransportServer and GlobalConfiguration to v1 #4251

Closed
brianehlert opened this issue Aug 16, 2023 · 4 comments · Fixed by #4574
Closed

Graduate TransportServer and GlobalConfiguration to v1 #4251

brianehlert opened this issue Aug 16, 2023 · 4 comments · Fixed by #4574
Assignees
Labels
backlog Pull requests/issues that are backlog items proposal An issue that proposes a feature request
Milestone

Comments

@brianehlert
Copy link
Collaborator

brianehlert commented Aug 16, 2023

During the process of raising the NGINX Ingress Controller specific CRDs to v1, the TransportServer object was forgotten.
We need to remedy this.

Acceptance Criteria:

  • advance TransportServer versioning to v1
  • provide in-box backward compatibility for the current v1alpha1
  • provide in-box deprecation message about TransportServer v1alpha1 (log message, Event on object)
  • advance GlobalConfiguration versioning to v1
  • provide in-box backward compatibility for the current v1alpha1
  • provide in-box deprecation message about GlobalConfiguration v1alpha1 (log message, Event on object)
  • Remove previewpolicy flag (long deprecated and no longer in use)
### Tasks
- [x] Update CRDs in both `chats/nginx-ingress/crds/` and `deploy/crds.yaml`
- [x] Graduate TransportServer to V1
- [x] Graduate GlobalConfiguration to V1
- [x] Update documentation around graduation of TS and GC
- [x] Test deployments of TS and GC using Helm and deploy manually with `deploy/crds.yaml`
@brianehlert brianehlert added proposal An issue that proposes a feature request backlog Pull requests/issues that are backlog items labels Aug 16, 2023
@brianehlert brianehlert added this to the v3.3.0 milestone Aug 16, 2023
@vepatel
Copy link
Contributor

vepatel commented Aug 17, 2023

@brianehlert should we create one for GlobalConfiguration as well?

@brianehlert
Copy link
Collaborator Author

@brianehlert should we create one for GlobalConfiguration as well?

We can extend this to cover both and have sub tasks for implementation if that is needed.
Or write a second one. It is simply about how the work is tracked.

@brianehlert brianehlert changed the title Advance TransportServer to v1 Advance TransportServer and GlobalConfiguration to v1 Sep 7, 2023
@brianehlert brianehlert changed the title Advance TransportServer and GlobalConfiguration to v1 Graduate TransportServer and GlobalConfiguration to v1 Sep 7, 2023
@vepatel
Copy link
Contributor

vepatel commented Sep 7, 2023

refer:

@brianehlert brianehlert modified the milestones: v3.3.0, v3.4.0 Sep 20, 2023
@danielnginx
Copy link
Collaborator

As reminder: Run make crds before check in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Pull requests/issues that are backlog items proposal An issue that proposes a feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants