Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

derivesFrom is not a property of Sample #51

Closed
kMutagene opened this issue Mar 3, 2025 · 0 comments · Fixed by #54
Closed

derivesFrom is not a property of Sample #51

kMutagene opened this issue Mar 3, 2025 · 0 comments · Fixed by #54

Comments

@kMutagene
Copy link
Member

While checking if the mappings are in sync with the profile, i stumbled across the derivesFrom property of our Sample profile.

  • The mapping marks it as unmapped redundant information
  • The profile has it as COULD property

There are requests to support it, e.g. nfdi4plants/ARCtrl#412 (although that one is concerned with isa json). On the other hand, there is no derivesFrom property of bioschemas.org/Sample, so the current profile seems to be flase in that regard.

My suggestion would be removing it for the incoming (and pressing) 1.0 release of the profile. We are not using it anyways, and proper support would IMO go over suggesting the property on the bioschemas type.

cc @HLWeil @floWetzels

@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Mar 3, 2025
@kMutagene kMutagene linked a pull request Mar 4, 2025 that will close this issue
@kMutagene kMutagene removed the Status: Needs Triage This item is up for investigation. label Mar 4, 2025
@kMutagene kMutagene moved this to Done in ARCStack Mar 4, 2025
@kMutagene kMutagene closed this as completed by moving to Done in ARCStack Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant