-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Volcano plot in report shows less genes than in 'plots/differential/*/png/volcano.png' #340
Comments
Seems like a duplicate of #270 |
Ok, so its finally working using |
Hello @d4straub! I need some more details to better understand your problem. But more important, what did you mean by: About the warning, there's no specific number to say that there are few differentially expressed genes, that really depends on the experiment |
Hi @alanmmobbs93 ,
true, at least the legend says so... I didnt spot that
I assume (I didnt check any code) that the two tables (DESeq2's statistics and annotation table) are merged with settings that drop features that are not present in the annotation table and are therefore lost. If that would be the case, just changing the merging conditions to keep all rows in the statistics table might fix the issue.
Indeed, the number of significant genes depends on the experiments, but it should not differ for comparisons within a pipeline run in different tables/figures. I meant to check the number of (significant or just total) features in the DESeq2 statistics versus the number of features plotted. If thats not the same, something is off and a warning/error is warranted I think. |
Hello @d4straub again! Thanks for the long explanation, it's clear now
This makes sense because you have no value to plot. Maybe adding a warning or caption to print how many NA features are would help. At least in my own experience, this is informative.
If the feature is not present in the annotation table (I think you refer to the tsv created after the reference GTF), I don't think why it would enter into DESeq module. In addition, some rows may be filtered out because of low expression before getting into DESeq2, so they wouldn't be there neither I'll work on this, in the meantime, just let me know if you have any new comment |
Thanks for looking into this!
Apologies for being ambiguous, indeed, I refer to
I dont really get that. Filtering is fine, but why would features be omitted from the count table based on missing values in the GTF? I understood and welcome that the metadata (via |
@d4straub The counts table is not filtered by the GTF. However, I'm not an expert on bacteria and with my previous message I was wondering why you would have a counts table with genes that are not present in your reference GTF, so I can better understand your context. But in order to be clear, your problem is that you got fewer genes on the volcano plots and DESeq2 output tables than on your input, am I right? I got a little confused on which exactly the issue is. |
No.
Unfortunately I am not at liberty to share the data. But
Next I run nf-core/differentialabundance with:
Please do not make me detail how I had to trick nf-core/rnaseq into doing what I want, thats a nightmare. |
THanks @alanmmobbs93 for fixing this :) |
Description of the bug
The volcano plots in
results/report/study.html#Differential_analysis
differ to the ones inresults/plots/differential/*/png/volcano.png
, screenshots below.I strongly assume its caused by the gtf I used. I downloaded gtfs from NCBI for non-standard organisms (bacteria). While I acknowledge that the gtfs might not follow standards (even if its coming from a popular resource) it is worrisome that the figure differ without any warning or error.
I havent investigated the issue, but I assume its related to qbic-pipelines/rnadeseq#216. Most likely I will tackle that problem in the next days and might be able to point to the reason.
Command used and terminal output
No response
Relevant files
results/report/study.html#Differential_analysis
results/plots/differential/*/png/volcano.png
System information
Version of nf-core/differentialabundance 1.5.0
The text was updated successfully, but these errors were encountered: