Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New output directory structure #222

Merged
merged 7 commits into from
Nov 19, 2024
Merged

New output directory structure #222

merged 7 commits into from
Nov 19, 2024

Conversation

nvnieuwk
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nvnieuwk
Copy link
Member Author

Don't merge before #213 has been merged

Base automatically changed from output-defs to dev November 14, 2024 08:12
@nvnieuwk
Copy link
Member Author

The new output directory now looks like this (for the test profile):

results/
├── Proband_12345
│   ├── NA24143_v1_9_0dev_2024_11_07
│   │   ├── NA24143.bed
│   │   ├── NA24143.haplotypecaller.bcftools_stats.txt
│   │   ├── NA24143.haplotypecaller.g.vcf.gz
│   │   └── NA24143.haplotypecaller.g.vcf.gz.tbi
│   ├── NA24149_v1_9_0dev_2024_11_07
│   │   ├── NA24149.bed
│   │   ├── NA24149.haplotypecaller.bcftools_stats.txt
│   │   ├── NA24149.haplotypecaller.g.vcf.gz
│   │   └── NA24149.haplotypecaller.g.vcf.gz.tbi
│   ├── NA24385_v1_9_0dev_2024_11_07
│   │   ├── NA24385.bed
│   │   ├── NA24385.haplotypecaller.bcftools_stats.txt
│   │   ├── NA24385.haplotypecaller.g.vcf.gz
│   │   └── NA24385.haplotypecaller.g.vcf.gz.tbi
│   ├── output_v1_9_0dev_2024_11_07
│   │   ├── automap
│   │   │   └── haplotypecaller
│   │   │       ├── sample1
│   │   │       │   ├── sample1.HomRegions.cmgg_bio.tsv
│   │   │       │   ├── sample1.HomRegions.pdf
│   │   │       │   ├── sample1.HomRegions.strict.cmgg_bio.tsv
│   │   │       │   └── sample1.HomRegions.tsv
│   │   │       ├── sample2
│   │   │       │   ├── sample2.HomRegions.cmgg_bio.tsv
│   │   │       │   ├── sample2.HomRegions.pdf
│   │   │       │   ├── sample2.HomRegions.strict.cmgg_bio.tsv
│   │   │       │   └── sample2.HomRegions.tsv
│   │   │       └── sample3
│   │   │           ├── sample3.HomRegions.cmgg_bio.tsv
│   │   │           ├── sample3.HomRegions.pdf
│   │   │           ├── sample3.HomRegions.strict.cmgg_bio.tsv
│   │   │           └── sample3.HomRegions.tsv
│   │   ├── Proband_12345.haplotypecaller.bed
│   │   ├── Proband_12345.haplotypecaller.db
│   │   ├── Proband_12345.haplotypecaller.ped
│   │   ├── Proband_12345.haplotypecaller.vcf.gz
│   │   └── Proband_12345.haplotypecaller.vcf.gz.tbi
│   └── qc_v1_9_0dev_2024_11_07
│       ├── Proband_12345.haplotypecaller.bcftools_stats.txt
│       └── Proband_12345.haplotypecaller.html
└── v1_9_0dev_2024_11_07
    ├── execution_report_2024-11-07_17-33-49.html
    ├── execution_timeline_2024-11-07_17-33-49.html
    ├── execution_trace_2024-11-07_17-33-49.html
    ├── multiqc_report.html
    ├── params_2024-11-07_17-34-02.json
    ├── pipeline_dag_2024-11-07_17-33-49.html
    ├── pipeline_software_mqc_versions.yml
    └── samplesheet.csv

This was referenced Nov 14, 2024
// Nextflow plugins
plugins {
id '[email protected]' // Validation of pipeline parameters and creation of an input channel from a sample sheet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waarom de revert?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a version bump, not a revert :)

Copy link
Member

@matthdsm matthdsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, One small question

@nvnieuwk nvnieuwk merged commit 63db893 into dev Nov 19, 2024
32 checks passed
@nvnieuwk nvnieuwk deleted the new-output-dir branch November 19, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants