From 62601e4977c7ca080faedf2782864bd07867f754 Mon Sep 17 00:00:00 2001 From: times-tools Date: Fri, 3 Jan 2025 15:30:50 +0000 Subject: [PATCH] fix web test --- .../__tests__/web/__snapshots__/article.web.test.js.snap | 3 --- .../__tests__/web/__snapshots__/article.web.test.js.snap | 4 ---- .../__tests__/web/__snapshots__/article.web.test.js.snap | 3 --- .../__tests__/web/__snapshots__/article.web.test.js.snap | 4 ---- packages/article-skeleton/src/article-skeleton.js | 6 +----- 5 files changed, 1 insertion(+), 19 deletions(-) diff --git a/packages/article-in-depth/__tests__/web/__snapshots__/article.web.test.js.snap b/packages/article-in-depth/__tests__/web/__snapshots__/article.web.test.js.snap index 542292ab79c..eb02149a234 100644 --- a/packages/article-in-depth/__tests__/web/__snapshots__/article.web.test.js.snap +++ b/packages/article-in-depth/__tests__/web/__snapshots__/article.web.test.js.snap @@ -213,7 +213,6 @@ exports[`3. an article with no headline falls back to use shortheadline 1`] = ` articleUrl="https://url.io" commentsEnabled={true} domainSpecificUrl="https://www.thetimes.co.uk" - isCommentEnabled={true} isSharingSavingEnabled={true} publishedTime="2015-03-13T18:54:58.000Z" relatedArticleSlice={ @@ -501,7 +500,6 @@ exports[`4. an article with ads with .co.uk 1`] = ` articleUrl="https://url.io" commentsEnabled={true} domainSpecificUrl="https://www.thetimes.co.uk" - isCommentEnabled={true} isSharingSavingEnabled={true} publishedTime="2015-03-13T18:54:58.000Z" relatedArticleSlice={ @@ -789,7 +787,6 @@ exports[`5. an article with ads with .com 1`] = ` articleUrl="https://url.io" commentsEnabled={true} domainSpecificUrl="www.thetimes.com" - isCommentEnabled={true} isSharingSavingEnabled={true} publishedTime="2015-03-13T18:54:58.000Z" relatedArticleSlice={ diff --git a/packages/article-magazine-comment/__tests__/web/__snapshots__/article.web.test.js.snap b/packages/article-magazine-comment/__tests__/web/__snapshots__/article.web.test.js.snap index b72c399cbe3..8c40aae449b 100644 --- a/packages/article-magazine-comment/__tests__/web/__snapshots__/article.web.test.js.snap +++ b/packages/article-magazine-comment/__tests__/web/__snapshots__/article.web.test.js.snap @@ -203,7 +203,6 @@ exports[`3. an article with no headline falls back to use shortheadline 1`] = ` articleUrl="https://url.io" commentsEnabled={true} domainSpecificUrl="https://www.thetimes.co.uk" - isCommentEnabled={true} isSharingSavingEnabled={true} publishedTime="2015-03-13T18:54:58.000Z" relatedArticleSlice={ @@ -481,7 +480,6 @@ exports[`4. an article with ads with .co.uk 1`] = ` articleUrl="https://url.io" commentsEnabled={true} domainSpecificUrl="https://www.thetimes.co.uk" - isCommentEnabled={true} isSharingSavingEnabled={true} publishedTime="2015-03-13T18:54:58.000Z" relatedArticleSlice={ @@ -759,7 +757,6 @@ exports[`5. an article with ads with .com 1`] = ` articleUrl="https://url.io" commentsEnabled={true} domainSpecificUrl="www.thetimes.com" - isCommentEnabled={true} isSharingSavingEnabled={true} publishedTime="2015-03-13T18:54:58.000Z" relatedArticleSlice={ @@ -1053,7 +1050,6 @@ exports[`8. an article with no author 1`] = ` articleUrl="https://url.io" commentsEnabled={true} domainSpecificUrl="https://www.thetimes.co.uk" - isCommentEnabled={true} isSharingSavingEnabled={true} publishedTime="2015-03-13T18:54:58.000Z" relatedArticleSlice={ diff --git a/packages/article-magazine-standard/__tests__/web/__snapshots__/article.web.test.js.snap b/packages/article-magazine-standard/__tests__/web/__snapshots__/article.web.test.js.snap index e669f0d6df2..65560bb54ce 100644 --- a/packages/article-magazine-standard/__tests__/web/__snapshots__/article.web.test.js.snap +++ b/packages/article-magazine-standard/__tests__/web/__snapshots__/article.web.test.js.snap @@ -216,7 +216,6 @@ exports[`3. an article with no headline falls back to use shortheadline 1`] = ` articleUrl="https://url.io" commentsEnabled={true} domainSpecificUrl="https://www.thetimes.co.uk" - isCommentEnabled={true} isSharingSavingEnabled={true} publishedTime="2015-03-13T18:54:58.000Z" relatedArticleSlice={ @@ -507,7 +506,6 @@ exports[`4. an article with ads with .co.uk 1`] = ` articleUrl="https://url.io" commentsEnabled={true} domainSpecificUrl="https://www.thetimes.co.uk" - isCommentEnabled={true} isSharingSavingEnabled={true} publishedTime="2015-03-13T18:54:58.000Z" relatedArticleSlice={ @@ -798,7 +796,6 @@ exports[`5. an article with ads with .com 1`] = ` articleUrl="https://url.io" commentsEnabled={true} domainSpecificUrl="www.thetimes.com" - isCommentEnabled={true} isSharingSavingEnabled={true} publishedTime="2015-03-13T18:54:58.000Z" relatedArticleSlice={ diff --git a/packages/article-main-comment/__tests__/web/__snapshots__/article.web.test.js.snap b/packages/article-main-comment/__tests__/web/__snapshots__/article.web.test.js.snap index 148ca589f83..3140818895b 100644 --- a/packages/article-main-comment/__tests__/web/__snapshots__/article.web.test.js.snap +++ b/packages/article-main-comment/__tests__/web/__snapshots__/article.web.test.js.snap @@ -188,7 +188,6 @@ exports[`3. an article with no headline falls back to use shortheadline 1`] = ` articleUrl="https://url.io" commentsEnabled={true} domainSpecificUrl="https://www.thetimes.co.uk" - isCommentEnabled={true} isSharingSavingEnabled={true} publishedTime="2015-03-13T18:54:58.000Z" relatedArticleSlice={ @@ -451,7 +450,6 @@ exports[`4. an article with ads with .co.uk 1`] = ` articleUrl="https://url.io" commentsEnabled={true} domainSpecificUrl="https://www.thetimes.co.uk" - isCommentEnabled={true} isSharingSavingEnabled={true} publishedTime="2015-03-13T18:54:58.000Z" relatedArticleSlice={ @@ -714,7 +712,6 @@ exports[`5. an article with ads with .com 1`] = ` articleUrl="https://url.io" commentsEnabled={true} domainSpecificUrl="www.thetimes.com" - isCommentEnabled={true} isSharingSavingEnabled={true} publishedTime="2015-03-13T18:54:58.000Z" relatedArticleSlice={ @@ -1042,7 +1039,6 @@ exports[`6. an article with puzzle sidebar 1`] = ` articleUrl="https://url.io" commentsEnabled={true} domainSpecificUrl="https://www.thetimes.co.uk" - isCommentEnabled={true} isSharingSavingEnabled={true} publishedTime="2015-03-13T18:54:58.000Z" relatedArticleSlice={ diff --git a/packages/article-skeleton/src/article-skeleton.js b/packages/article-skeleton/src/article-skeleton.js index 8ce49d495ce..7e62bb20f00 100644 --- a/packages/article-skeleton/src/article-skeleton.js +++ b/packages/article-skeleton/src/article-skeleton.js @@ -88,9 +88,7 @@ const ArticleSkeleton = ({ sharingEnabled, publishedTime, isSavingEnabled, - isSharingEnabled, - isCommentEnabled, - isEntitlementFeatureEnabled + isSharingEnabled } = article; const [showVerifyEmailBanner, setShowEmailVerifyBanner] = useState(false); @@ -448,11 +446,9 @@ const ArticleSkeleton = ({ commentingConfig={commentingConfig} topics={topics} isSharingSavingEnabled={isSharingSavingEnabled} - isCommentEnabled={isCommentEnabled} storefrontConfig={storefrontConfig} breadcrumbs={breadcrumbs} domainSpecificUrl={domainSpecificUrl} - isEntitlementFeatureEnabled={isEntitlementFeatureEnabled} /> )}