Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use latest operator-sdk #170

Merged
merged 17 commits into from
Jan 8, 2025
Merged

feat: Use latest operator-sdk #170

merged 17 commits into from
Jan 8, 2025

Conversation

dbudziwojskiNR
Copy link
Contributor

@dbudziwojskiNR dbudziwojskiNR commented Dec 23, 2024 •
edited
Loading

Description

Updated operator to use the latest SDK. Removed dependency on kube-rbac-proxy (Resolves #167).

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

@codecov Codecov
Copy link

codecov bot commented Dec 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 63.55140% with 39 lines in your changes missing coverage. Please review.

Project coverage is 67.20%. Comparing base (ba9fddd) to head (203d8fc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/api/v1alpha2/instrumentation_webhook.go 45.71% 30 Missing and 8 partials ⚠️
src/internal/webhook/podmutationhandler.go 97.05% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
+ Coverage   60.31%   67.20%   +6.89%     
==========================================
  Files          22       21       -1     
  Lines        1532     1549      +17     
==========================================
+ Hits          924     1041     +117     
+ Misses        538      425     -113     
- Partials       70       83      +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbudziwojskiNR dbudziwojskiNR marked this pull request as ready for review January 7, 2025 20:26
@dbudziwojskiNR dbudziwojskiNR requested a review from a team as a code owner January 7, 2025 20:26
@dbudziwojskiNR dbudziwojskiNR merged commit b483638 into main Jan 8, 2025
20 checks passed
@dbudziwojskiNR dbudziwojskiNR deleted the dbudziwojski/update-scaffolding branch January 8, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielstokes danielstokes danielstokes approved these changes

Assignees
No one assigned
Labels
Release/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

⚠️ Action Required: Replace Deprecated gcr.io/kubebuilder/kube-rbac-proxy
2 participants
@dbudziwojskiNR @danielstokes