Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboards having single quote ('), slash (/) or colon (:) in the name not getting migrated #37

Open
OscarLopezEns opened this issue Oct 13, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@OscarLopezEns
Copy link

OscarLopezEns commented Oct 13, 2022

Dashboards having single quote ('), slash (/) or colon (:) in the name not getting migrated

Description

If a dashboard has a single quote in the name, the migrate_dashboards.py fails with "INVALID_INPUT" and "..not a valid NRQL query" error. If a slash (/) or colon (:) is in the name, the Dashboard is simply not found on the source account (and therefore not migrated) since the fetch entities script replaces slash (/) or colon (:) with the ~ character.

Steps to Reproduce

Test by using the migrate_dashboards.py script to migrate a Dashboard having single quote in the name. i.e. "Aaron's Test"

Expected Behavior

Dashboards having single quote in the name, slash (/) or colon (:) in the name should be able to get migrated.

Relevant Logs / Console output

2022-10-13 10:02:27,850 - migrate_dashboards.py - INFO - Dashboard migration started.
2022-10-13 10:02:27,856 - entityclient.py - INFO - Searching matching entity for type:DASHBOARD, name:Aaron's Test, acct:*****
2022-10-13 10:02:28,405 - entityclient.py - ERROR - {'entityFound': False, 'status': 200, 'error': [{'extensions': {'errorClass': 'INVALID_INPUT'}, 'locations': [{'column': 41, 'line': 3}], 'message': "Provided filter: [name = 'Aaron's Test' AND type = 'DASHBOARD' AND tags.accountId = '1006970'] is not a valid NRQL query", 'path': ['actor', 'entitySearch']}]}

@OscarLopezEns OscarLopezEns added the bug Something isn't working label Oct 13, 2022
@OscarLopezEns OscarLopezEns changed the title Dashboards having single quote (') in the name not getting migrated Dashboards having single quote (') or slash (/) in the name not getting migrated Oct 13, 2022
@OscarLopezEns OscarLopezEns changed the title Dashboards having single quote (') or slash (/) in the name not getting migrated Dashboards having single quote ('), slash (/) or colon (:) in the name not getting migrated Oct 13, 2022
@adiosspandit adiosspandit self-assigned this Oct 19, 2022
@adiosspandit
Copy link
Collaborator

Thanks for opening the bug @OscarLopezEns I am looking into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants