-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent project name and CMake options #355
Comments
I prefer to keep the project name as the more descriptive NEURON and also because that has been |
I also see the point of having I created this issue because we are using some utilities for code-formatting which automatically creates CMake options by using project name i.e. If we enable code formatting as:
Then following CMake variables are created: One way would be to optionally tell coding-convention utility to use Is that possible @tristan0x ? cc: @ohm314 |
If the coding convention utility can be made to use NRN then great. Otherwise I think the only choice is to leave some mixed NEURON and NRN or to universally in cmake change all NRN to NEURON. I don't mind except for the trivial extra name lengths and the cursing that results when one types NERUON |
I think we should be able to adjust hpc-coding-conventions to take the desired name. If that is not possible, I also opt for using "NEURON" everywhere (and do some cursing :) ) |
I'm guessing your context is a bit narrower than that and refers only to the cmake options. The reasons NRN and nrn are so ubiquitous is their convenience. The 'nrniv', 'nrnoc', letter groups as well as strange names like nocmodl had perfectly reasonable origins in the oc, nrnoc, ivoc, nrniv folder structure but don't make as much sense as they used to. |
Yes, I meant in the context of cmake / the build system. in the source code I would think there is no need to rush with radical name changes and rather change names whenever it makes sense and eases maintenance or clarifies code. |
@ohm314 has done necessary change in BlueBrain/hpc-coding-conventions@0673881 |
@tristan0x has following comment in PR here:
For brevity we (including Michael) prefer
NRN
instead ofNEURON
.It would be ok to rename project name from NEURON to NRN provided that this doesn't affect other places. For example:
The text was updated successfully, but these errors were encountered: