Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions to standardise system dependencies #118

Open
bschilder opened this issue Nov 17, 2023 · 0 comments
Open

Add functions to standardise system dependencies #118

bschilder opened this issue Nov 17, 2023 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request GitHub Actions Issue occurring on GitHub Actions

Comments

@bschilder
Copy link
Collaborator

Right now there is a disconnect between the system dependencies lists in the Dockerfile and those in the rworkflows action.

RUN apt-get update && \

sysreqs=$(Rscript -e 'cat("apt-get update -y && apt-get install -y", paste(gsub("apt-get install -y ", "", remotes::system_requirements("ubuntu", "20.04")), collapse = " "))')

I could resolve this by copying-and-pasting any updates to all locations where this is relevant, or i could add some R functions to keep track the system dependencies (and what commands should be used to install them on each OS) in one place.

Thus, I've added new functions and implemented in the action and all relevant files (on the dev branch):

  • New functions:
    • dependencies_linux
    • dependencies_macos
    • dependencies_windows
    • dependencies_latex
@bschilder bschilder self-assigned this Nov 17, 2023
@bschilder bschilder added documentation Improvements or additions to documentation enhancement New feature or request GitHub Actions Issue occurring on GitHub Actions labels Nov 17, 2023
@bschilder bschilder moved this from Todo to In Progress in Project Management Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request GitHub Actions Issue occurring on GitHub Actions
Projects
Status: In Progress
Development

No branches or pull requests

1 participant