Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented: Version 8.0.0 composer dependencies require PHP >= 8.0.0 #1591

Closed
fcorrigabb opened this issue Feb 26, 2025 · 7 comments
Closed
Labels

Comments

@fcorrigabb
Copy link

As stated in the title.

Image

@fcorrigabb fcorrigabb added the bug label Feb 26, 2025
@fcorrigabb
Copy link
Author

This is the commit causing the issue:
8631cf0

There is no trace of that requirement change in the release notes

@hostep
Copy link
Contributor

hostep commented Feb 26, 2025

How do you mean, it's the first line in the changelog? :D

https://github.com/netz98/n98-magerun2/blob/develop/CHANGELOG.md

8.0.0
Major: Drop PHP 7 support
...

And is mentioned in the announcement: https://magerun.net/n98-magerun2-v8-0-0/

This release marks a significant milestone in our journey, especially with the decision to drop PHP 7 support—a bold step towards a more modern and efficient future.

@fcorrigabb
Copy link
Author

Yes, it's in the changelog but not on the release notes: https://github.com/netz98/n98-magerun2/releases/tag/8.0.0

@cmuench
Copy link
Member

cmuench commented Feb 26, 2025

@fcorrigabb the GitHub Release is auto generated and we introduced the releases only to support the nix project.
Sorry that you had issues but we have reported this major change on several places.
It's technically available as dependency in the compose.json.
Also in the changelog in the repository. In the official blog post. We use semantic versioning and changed the major version.

@fcorrigabb
Copy link
Author

fcorrigabb commented Feb 26, 2025

Not really a problem, I just reported the change was missing from the release notes.
Thanks for your time

@cmuench
Copy link
Member

cmuench commented Feb 26, 2025

@fcorrigabb I thought you had some trouble with the release. I just modified the automatic created release info in the Github Release. Thanks for reporting.

@cmuench
Copy link
Member

cmuench commented Feb 26, 2025

@fcorrigabb I close this issue due to the change in the release info.

@cmuench cmuench closed this as completed Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants