Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on a few page features #319

Closed
sdras opened this issue Nov 14, 2020 · 6 comments · May be fixed by #340
Closed

Decide on a few page features #319

sdras opened this issue Nov 14, 2020 · 6 comments · May be fixed by #340
Assignees
Milestone

Comments

@sdras
Copy link
Contributor

sdras commented Nov 14, 2020

For Monday:

  • The progress tracker is confusing, what's the expected behavior?
  • Explorers down the side: does it make sense to keep it?
@sdras sdras added this to the Launch milestone Nov 14, 2020
@jlengstorf
Copy link
Contributor

what about having the fraction be current video and adding a progress bar by the mission name to show how much of the mission is complete?

kind of a "you're viewing stage 2 of 5; you're 80% done with this mission"

@sdras
Copy link
Contributor Author

sdras commented Nov 14, 2020

oh I like that idea, that's more explicit!

@philhawksworth
Copy link
Contributor

I've never quite understood this:

Explorers down the side: does it make sense to keep it?

So I'd advocate for losing it :)

@sdras
Copy link
Contributor Author

sdras commented Nov 18, 2020

We actually dealt with that one in a PR this weekend, where I made it smaller and less opaque. It's a design enhancement, let's keep that for now, and if people REALLY hate it we can lose it.

@bencodezen
Copy link
Contributor

So the only thing left is the percentage. Is it worth closing this @sdras for now since I think we have everything else we need for launch?

@sdras
Copy link
Contributor Author

sdras commented Nov 18, 2020

yeah! we could create a new issue, but really, you did a great job of the draft PR, it's on my list to iterate there.

@sdras sdras closed this as completed Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants