Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectOptionsImplementation fails to restore form state for 'integer' option values #23

Open
patricekaufmann opened this issue Sep 9, 2020 · 0 comments

Comments

@patricekaufmann
Copy link

The follwing comparison in SelectOptionsImplementation.php fails for integer option values (eg. 1) since the types don't match. Hence the form values will be lost when restoring the form state after failed validation.

 private function isOptionSelected($optionValue): bool
    {
        $elementValue = ($this->runtime->getCurrentContext())['elementValue'] ?? null;
        if ($optionValue === $elementValue) {
            return true;
        }
        if (is_array($elementValue) && in_array($optionValue, $elementValue)) {
            return true;
        }
        return false;
    }

Suggested Fix: cast $optionValue as string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant