New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pageserver: faulty secondary download layer size check #10308

Open

erikgrinaker opened this issue Jan 8, 2025 · 0 comments

Labels

c/storage/pageserver t/bug t/on_call_followup

Contributor

erikgrinaker commented Jan 8, 2025

During deployments, we've seen a fair number of these warnings:

2025-01-08T12:11:29.166095Z WARN secondary_download{tenant_id=foo shard_id=0608}: Removing local layer 000000067F00004005000041430000430000-000000067F00004005000041430300000000__00000039B1234310 with unexpected local size 66379776 != 59826176

These have previously been rewritten by compaction:

2025-01-08T12:10:42.878774Z  INFO compaction_loop{tenant_id=foo shard_id=0608}:run:compact_timeline{timeline_id=bar}: Rewrote layer, 66379776 -> 59826176 bytes layer=000000067F00004005000041430000430000-000000067F00004005000041430300000000__00000039B1234310-00000007

This doesn't appear to be a correctness problem, but we should tighten up the logic to handle this case.

The text was updated successfully, but these errors were encountered:

erikgrinaker added c/storage/pageserver t/bug t/on_call_followup labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment