Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installed neoforge server doesn't check for java version #1890

Open
SAKO4444GODZ opened this issue Jan 23, 2025 · 0 comments
Open

Installed neoforge server doesn't check for java version #1890

SAKO4444GODZ opened this issue Jan 23, 2025 · 0 comments

Comments

@SAKO4444GODZ
Copy link

run.sh and run.bat both do not check for the version of the java binary that they will invoke. At least on Linux, this means that using Java 8 instead of 21 will cause the script to not fully execute (literally fails trying to use the user_jvm_args.txt).

Steps to reproduce:

set default java binary to the wrong version (eg. archlinux-java set openjdk-8)
install neoforge server (eg. the latest 1.21.4 beta)
./run.sh or ./run.bat
script errors; no server files generated

Possible fixes:
-Include java in server files (download while generating run.sh or include it in the jar)
-Have run.sh check for available java binaries
-Have run.sh download an appropriate java binary on first use, and use it each time
-Spit out an error if java version is inappropriate

(run.sh or run.bat) (first fix is stupid but works anyway)

If more information is needed feel free to reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant