Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support authentication on root custom resolver fields #4816

Merged
merged 8 commits into from
Mar 7, 2024

Conversation

a-alle
Copy link
Contributor

@a-alle a-alle commented Mar 4, 2024

Description

Adds support for the @authentication directive on custom resolved fields of root types Query and Mutation.
Fixes #3746

Complexity

Complexity: Low

Issue

Note

Please link to the GitHub issue(s) in which the proposal for this work was discussed

To link to multiple issues, use full syntax for each, for example Closes #1, closes #2, closes #3

Closes

Checklist

The following requirements should have been met (depending on the changes in the branch):

  • Documentation has been updated
  • TCK tests have been updated
  • Integration tests have been updated
  • Example applications have been updated
  • New files have copyright header
  • CLA (https://neo4j.com/developer/cla/) has been signed

@a-alle a-alle requested a review from darrellwarde March 4, 2024 11:29
Copy link

changeset-bot bot commented Mar 4, 2024

🦋 Changeset detected

Latest commit: ca69be9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@neo4j/graphql Minor
@neo4j/graphql-toolbox Patch
@neo4j/graphql-ogm Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Mar 4, 2024

Thanks for the Neo4j GraphQL Toolbox updates.

The Neo4j GraphQL Toolbox has now been torn down - reopening this PR will republish it.

Copy link
Contributor

@darrellwarde darrellwarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a high-level comment on this one, which as I say, I am happy to have a chat about - perhaps there is more complexity here that I'm not seeing!

@a-alle a-alle requested a review from MacondoExpress March 4, 2024 12:00
@a-alle a-alle requested a review from darrellwarde March 4, 2024 12:23
darrellwarde
darrellwarde previously approved these changes Mar 5, 2024
Copy link
Contributor

@darrellwarde darrellwarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I think this is looking good!

@a-alle a-alle merged commit 6b547dd into neo4j:dev Mar 7, 2024
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Pull requests
Development

Successfully merging this pull request may close these issues.

Allow @authentication directive to be used with custom resolvers
3 participants