Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Desktop ...? #440

Closed
nelsonic opened this issue Dec 27, 2017 · 4 comments
Closed

GitHub Desktop ...? #440

nelsonic opened this issue Dec 27, 2017 · 4 comments
Labels
discuss Share your constructive thoughts on how to make progress with this issue question A question needs to be answered before progress can be made on this issue starter A beginner-friendly issue that is a good starting point for a new person

Comments

@nelsonic
Copy link
Owner

While reviewing a "Mega PR" (tens of thousands of lines of code!)
I realised that I had no way of efficiently reviewing the changes
(I was reviewing in the browser but each time I tried to expand the file to see all the changes it would "hang" in Chrome and Firefox ... because the browser had already loaded a lot of data...)

Additionally I was unable to "load up" several PRs when I had good internet and then view them offline (when no internet is available...) because again, my Web Browser would grind to a halt...!

Decided to try GitHub Desktop to see if it can help: https://desktop.github.com
image

Obviously it requires "Full Access":
image

Testing it now...
After authenticating I see this:
image

Not a very helpful "home screen" for an existing user ... 🙄

@nelsonic nelsonic added discuss Share your constructive thoughts on how to make progress with this issue question A question needs to be answered before progress can be made on this issue starter A beginner-friendly issue that is a good starting point for a new person labels Dec 27, 2017
@nelsonic
Copy link
Owner Author

An example of an "XXL" Open Source PR: dwyl/english-words#35
image

Sadly when I attempt to view the PR in GitHub desktop I get the following Error:
github-desktop-file-too-large

In other words, for Large Pull Requests with many changes in files, GitHub Desktop is useless. 😞

@nelsonic
Copy link
Owner Author

Deleted the app. useless. 😕
Might consider an alternative Git GUI but for now just going to use CLI. 🙄

@MysticMight
Copy link

MysticMight commented Feb 25, 2018

@nelsonic have you tried SourceTree, it is similar to the GitHub Desktop app, though different layout etc. I am not sure if this will fix your issue though, I haven't dealt with large file commits.

I did a bit of research on the file limit and it looks like Git-LFS was designed for large files (https://git-lfs.github.com/) source: desktop/desktop#2213.
By default it can be used with command line but it also looks like it can be used with Github Desktop: https://github.com/blog/2079-managing-large-files-with-git-lfs

Edit: This is perhaps also useful for others that come across this 'issue', though I haven't tested it because I don't deal with large file commits.

@nelsonic
Copy link
Owner Author

@MysticMight thanks for sharing your research. 🔍 👍
SourceTree was the original app I/we used for source control ...
Sadly, SourceTree does not display "Large Files" ...
also, I stopped using SourceTree because it requires Admin Access
to everything on my GitHub account:
image
I want to authorise an app to have access to only a specific subset of my projects and only with the minimum privileges required to get it's "work" done. i.e. push & pull code.
see: https://en.wikipedia.org/wiki/Principle_of_least_privilege

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Share your constructive thoughts on how to make progress with this issue question A question needs to be answered before progress can be made on this issue starter A beginner-friendly issue that is a good starting point for a new person
Projects
None yet
Development

No branches or pull requests

2 participants