From 899cc3e524f1146dac56e88526d80e6abc8a69a1 Mon Sep 17 00:00:00 2001 From: Bryan Culver Date: Wed, 7 Jun 2023 13:56:53 -0400 Subject: [PATCH 1/4] Ready release of v1.4.1 --- CHANGELOG.md | 6 ++++++ pyproject.toml | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index bf6bb7a..3f2bf4a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,11 @@ # Nautobot Secrets Providers Changelog +## v1.4.1 (2023-06-07) + +### Fixed + +- [#91](https://github.com/nautobot/nautobot-plugin-secrets-providers/issues/91) Fixed Hashicorp Vault Authentication with AWS Credentials when region is not set. + ## v1.4.0 (2023-04-19) ### Added diff --git a/pyproject.toml b/pyproject.toml index a8a42d5..23ac173 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,6 +1,6 @@ [tool.poetry] name = "nautobot-secrets-providers" -version = "1.4.1-beta.1" +version = "1.4.1" description = "Nautobot Secrets Providers Plugin." authors = ["Network to Code, LLC "] license = "Apache-2.0" From 5cc43f778b21ab61347830e68030402e184d33b4 Mon Sep 17 00:00:00 2001 From: Bryan Culver <31187+bryanculver@users.noreply.github.com> Date: Wed, 7 Jun 2023 15:33:54 -0400 Subject: [PATCH 2/4] Update nautobot_secrets_providers/providers/hashicorp.py Co-authored-by: Hanlin Miao <46973263+HanlinMiao@users.noreply.github.com> --- nautobot_secrets_providers/providers/hashicorp.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/nautobot_secrets_providers/providers/hashicorp.py b/nautobot_secrets_providers/providers/hashicorp.py index c075acf..96c1ef2 100644 --- a/nautobot_secrets_providers/providers/hashicorp.py +++ b/nautobot_secrets_providers/providers/hashicorp.py @@ -151,9 +151,7 @@ def get_client(cls, secret=None): elif auth_method == "aws": session = boto3.Session() aws_creds = session.get_credentials() - aws_region = session.region_name - if aws_region is None: - aws_region = "us-east-1" + aws_region = session.region_name or "us-east-1" client.auth.aws.iam_login( access_key=aws_creds.access_key, secret_key=aws_creds.secret_key, From 1c0a9e97b7e809e570cb8875d30fc07cff280e30 Mon Sep 17 00:00:00 2001 From: Hanlin Miao Date: Fri, 29 Sep 2023 12:18:46 -0400 Subject: [PATCH 3/4] address PR feedback --- tasks.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tasks.py b/tasks.py index 745dc7a..3e16ffe 100644 --- a/tasks.py +++ b/tasks.py @@ -38,7 +38,7 @@ def is_truthy(arg): namespace.configure( { "nautobot_secrets_providers": { - "nautobot_ver": "latest", + "nautobot_ver": "stable", "project_name": "nautobot_secrets_providers", "python_ver": "3.8", "local": False, From e1b4ae4f98a0ee56b90a391226754abb5a2d97b0 Mon Sep 17 00:00:00 2001 From: Hanlin Miao Date: Fri, 29 Sep 2023 13:45:31 -0400 Subject: [PATCH 4/4] address Pr feedback --- .github/workflows/ci.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5827a82..8807f21 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -120,10 +120,8 @@ jobs: strategy: fail-fast: true matrix: - # TBD: Fix tested versions - # python-version: ["3.8", "3.9", "3.10", "3.11"] - python-version: ["3.8"] - nautobot-version: ["2.0.0"] + python-version: ["3.8", "3.11"] + nautobot-version: ["2.0.0", "stable"] db-backend: ["postgresql", "mysql"] runs-on: "ubuntu-20.04" env: