Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing Unit Tests in nanoframework.System.Net.Http #1464

Open
patagonaa opened this issue Apr 8, 2024 · 4 comments · May be fixed by nanoframework/System.Net.Http#439
Open

Failing Unit Tests in nanoframework.System.Net.Http #1464

patagonaa opened this issue Apr 8, 2024 · 4 comments · May be fixed by nanoframework/System.Net.Http#439

Comments

@patagonaa
Copy link
Contributor

Library/API/IoT binding

nanoFramework.System.Net.Http

Visual Studio version

No response

.NET nanoFramework extension version

No response

Target name(s)

No response

Firmware version

No response

Device capabilities

No response

Description

There are some Unit Tests failing in nanoframework.System.Net.Http.
Namely:

  • HttpUtilityTest.UrlEncodeTest
  • Miscellaneous tests in StreamContentTest

These are not new issues related to nanoframework/System.Net.Http#416, but have been there before.
Broken unit tests should be verified (if they point to an actual issue), then fixed or deleted.

How to reproduce

No response

Expected behaviour

No response

Screenshots

No response

Sample project or code

No response

Aditional information

No response

@mizady
Copy link
Contributor

mizady commented Dec 22, 2024

I'm gonna go ahead and go through these and clean up the tests a bit and verify which ones are working properly and not. It looks like the UriUnitTests are also in rough shape as well.

@josesimoes
Copy link
Member

@mizady awesome that you're willing to tackle this one! Thanks. 😃
Also, as we now have the wonderful hardware tests, HTTP is a great candidate to run those and be able to run real network tests on devices. That would be bonus score.😉

@mizady
Copy link
Contributor

mizady commented Dec 30, 2024

To note, the linked pull request should not close this issue. Though i believe it is required to solve this one. I will be posting a draft pull request soon that will have the url encoding/decoding tests and fixes, and the uri tests that seemed to be passing initially but upon closer inspection were not.

@josesimoes
Copy link
Member

@mizady noted. It's a matter of replacing the verb that links to this issue to not use one of the "key" ones 😉 (done!).
.

@mizady mizady linked a pull request Jan 3, 2025 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants