You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Suggest setting the ENV vars used by ENSRainbow to invalid values. Ex: directories or files that don't exist, or to invalid port values (ex: negative integers, etc.. please see definition of parseInt). Please also consider invalid INPUT_FILE values.
Goal: Ensure that in all cases the error messages are useful and would help someone to fix the incorrectly set ENV var.
I see that we already have some logic added for this inside apps/ensrainbow/src/index.ts, however:
Shouldn't we use similar logic in apps/ensrainbow/src/ingest.ts (and anywhere else relevant)?
Shouldn't we move this logic such that it is defined in only a single file and imported as needed?
Creating this story while reviewing PR 101.
Suggest setting the ENV vars used by ENSRainbow to invalid values. Ex: directories or files that don't exist, or to invalid port values (ex: negative integers, etc.. please see definition of
parseInt
). Please also consider invalidINPUT_FILE
values.Goal: Ensure that in all cases the error messages are useful and would help someone to fix the incorrectly set ENV var.
I see that we already have some logic added for this inside
apps/ensrainbow/src/index.ts
, however:apps/ensrainbow/src/ingest.ts
(and anywhere else relevant)?Also suggest writing utility functions that wrap reading values out of ENV vars. Please see utility functions in the following file for some inspirations: https://github.com/namehash/ensnode/blob/main/apps/ensnode/src/lib/ponder-helpers.ts
The text was updated successfully, but these errors were encountered: