Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine Plugin Registrars #115

Open
lightwalker-eth opened this issue Jan 30, 2025 · 0 comments
Open

Refine Plugin Registrars #115

lightwalker-eth opened this issue Jan 30, 2025 · 0 comments
Assignees
@tk-o
Labels
documentation Improvements or additions to documentation ensnode ENSNode related
Milestone
v1

Comments

@lightwalker-eth
Copy link
Member

Requests:

  1. For the base.eth Registrar handler I see the logic is in Registrar.ts, but for eth and linea.eth, I see the logic is in EthRegistrar.ts. Is there a special reason not to rename all these files to just Registrar.ts?
  2. There's a nice comment at the top of apps/ensnode/src/handlers/NameWrapper.ts that identifies the NFT token type issued by the NameWrapper. Ex: ERC1155. Can we please explicitly document the NFT token type issued by the other Registrars in the similar comment at the top of their Registrar.ts handlers?
@lightwalker-eth lightwalker-eth added the documentation Improvements or additions to documentation label Jan 30, 2025
@lightwalker-eth lightwalker-eth added this to the v1 milestone Jan 30, 2025
@lightwalker-eth lightwalker-eth added the ensnode ENSNode related label Jan 31, 2025
@lightwalker-eth lightwalker-eth moved this to Todo in ENSNode Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tk-o tk-o

Labels
documentation Improvements or additions to documentation ensnode ENSNode related
Projects
ENSNode
Status: Todo
Milestone
v1
Development

No branches or pull requests
2 participants
@tk-o @lightwalker-eth