Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnDemandRequester.get_counts_by_specimen doesn't error if none of the cells selected are in a specimen it looks at #251

Closed
CarlinLiao opened this issue Nov 17, 2023 · 0 comments · Fixed by #252
Assignees
Labels
bug Something isn't working

Comments

@CarlinLiao
Copy link
Collaborator

If the set of cells_selected passed to OnDemandRequester.get_counts_by_specimen does not contain any cells for one of the specimens it looks at, it'll error. This is a common occurrence because, in the case of importance scores which uses this function, we often exclude certain specimens from evaluating with the CG-GNN because they're from an irrelevant cohort. get_counts_by_specimen needs to be refactored to handle this gracefully.

@CarlinLiao CarlinLiao added the bug Something isn't working label Nov 17, 2023
@CarlinLiao CarlinLiao self-assigned this Nov 17, 2023
@CarlinLiao CarlinLiao changed the title OnDemandRequester.get_counts_by_specimen doesn't handle no cells selected properly OnDemandRequester.get_counts_by_specimen doesn't errors if none of the cells selected are in a specimen it looks at Nov 17, 2023
@CarlinLiao CarlinLiao changed the title OnDemandRequester.get_counts_by_specimen doesn't errors if none of the cells selected are in a specimen it looks at OnDemandRequester.get_counts_by_specimen doesn't error if none of the cells selected are in a specimen it looks at Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant