Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample names and protein acronyms are not well managed when retrieving samples from DRAC #1156

Open
antolinos opened this issue Feb 18, 2025 · 0 comments · May be fixed by #1166
Open

Sample names and protein acronyms are not well managed when retrieving samples from DRAC #1156

antolinos opened this issue Feb 18, 2025 · 0 comments · May be fixed by #1166
Assignees
@antolinos

Comments

@antolinos
Copy link
Contributor

Since the endpoint retrieves only a reference to the protein acronym and not the acronym itself, the sample name is currently used instead which is obviously not good

mxcubecore/mxcubecore/HardwareObjects/ICATLIMS.py

Line 204 in 1406ec9

"proteinAcronym": tracking_sample["name"],

mxcubecore/mxcubecore/HardwareObjects/ICATLIMS.py

Line 207 in 1406ec9

"sampleName": str(tracking_sample["name"]),

We need a way to retrieve the acronym from the sample Id
@antolinos antolinos self-assigned this Feb 21, 2025
@antolinos antolinos linked a pull request Feb 24, 2025 that will close this issue
Added get_samples function to retrieve the acronym #1166
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antolinos antolinos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added get_samples function to retrieve the acronym mxcube/mxcubecore
1 participant
@antolinos