Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:start param ignored in 1.0.3? #16

Open
danfunk opened this issue Jun 14, 2011 · 4 comments
Open

:start param ignored in 1.0.3? #16

danfunk opened this issue Jun 14, 2011 · 4 comments

Comments

@danfunk
Copy link

danfunk commented Jun 14, 2011

Previously Find would respect the inclusion of a :start param (rather than :page) but in v 1.0.3 the :start parameter is ignored if :per_page is specified. I think the cause is on line 18 of client.rb where you check for either a :page or a :per_page parameter.

@cbeer
Copy link
Contributor

cbeer commented Jun 21, 2011

I can confirm this behavior (introduced by commit 39601f9). In previous versions of rsolr-ext, as part of your query, you could provide the solr "rows" parameter. With rsolr-ext 1.0.3, you instead need to provide (exclusively) rsolr's page/per_page parameters. Any chance we could get the old behavior restored, in addition to the new rsolr paginate style?

@jrochkind
Copy link

matt, any comment?

@jrochkind
Copy link

this is trickling down to cause increasingly weird bugs in our code.

Solr "start" is 0-indexed, and also is an index into number of documents. RSolr#page is 1-indexed, and indexed into number of pages. Not the same thing at all. To remove our ability to use ordinary Solr#start is causing all sorts of hard to find bugs.

@knewter
Copy link

knewter commented Mar 2, 2012

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants