-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
:start param ignored in 1.0.3? #16
Comments
I can confirm this behavior (introduced by commit 39601f9). In previous versions of rsolr-ext, as part of your query, you could provide the solr "rows" parameter. With rsolr-ext 1.0.3, you instead need to provide (exclusively) rsolr's page/per_page parameters. Any chance we could get the old behavior restored, in addition to the new rsolr paginate style? |
matt, any comment? |
this is trickling down to cause increasingly weird bugs in our code. Solr "start" is 0-indexed, and also is an index into number of documents. RSolr#page is 1-indexed, and indexed into number of pages. Not the same thing at all. To remove our ability to use ordinary Solr#start is causing all sorts of hard to find bugs. |
+1 |
Previously Find would respect the inclusion of a :start param (rather than :page) but in v 1.0.3 the :start parameter is ignored if :per_page is specified. I think the cause is on line 18 of client.rb where you check for either a :page or a :per_page parameter.
The text was updated successfully, but these errors were encountered: