Mail Composer: Save draft

[benbucksch]

No description provided.

[benbucksch]

See EMail.ts line 610.

What happens is that JPC observe() function tries to serialize the entire object tree, starting with the email.folder and email.identity, and walking folder.messages, and serializing all messages. Obviously, that doesn't make sense.

[benbucksch]

@NeilRashbrook Could you help me out here, please? I'm stuck on this.

[NeilRashbrook]

You shouldn't be sending an email object across IPC. To generate MIME for a message, use await SMTPAccount.getMIME(email);. See

mustang/app/logic/Mail/ActiveSync/ActiveSyncAccount.ts

Line 122 in 20a2fd5

Mime: await SMTPAccount.getMIME(email),

observe() is a red herring; this would also happen with an object that doesn't support Svelte directly in createObjectDescription.

When sending an object across JPC, in order to accurately represent the object, all of its own properties also get sent, unless they begin with _, as those are assumed to be backing values for getters. Examples of own properties on the EMail object are to, cc, bcc, attachments, tags, headers, folder, storageLock, identity.

[NeilRashbrook]

(I don't know what happened to that link, it looked fine in preview.)

mustang/app/logic/Mail/ActiveSync/ActiveSyncAccount.ts

Line 122 in 20a2fd5

Mime: await SMTPAccount.getMIME(email),

[NeilRashbrook]

We haven't run into this before because none of our front end calls pass classes as parameters and most of them also return primitive values or plain objects. One obvious exception is our WebContents wrapper but that uses _win for its reference which avoids being serialised. I don't know about the other Node imports which we serialise from the backend to the front end (HTTPServer, ImapFlow, Database, Zip, shell, Tray, Notification, fs).

[NeilRashbrook]

Oh dear, circular reference time again...

[benbucksch]

@NeilRashbrook Thanks, Neil, for the good patch. I've landed something very similar on master.

We still have one problem: If I drag a file (e.g. a PDF file) into the mail composer as attachment, then save as draft, it saves apparently correctly. I can open the file while viewing the draft as message in the viewer (click on the attachment icon to open it in a local app). I can even re-open the draft, using the [Edit Draft] button, and the attachment shows up correctly in the mail composer again. However, I can then neither send nor save as draft again. I get error:
"Failed to execute 'readAsDataURL' on 'FileReader': parameter 1 is not of type 'Blob'.
Add recipient" from CreateMIME.getAttachment().

[NeilRashbrook]

I get Error: MIME source not yet downloaded after which things go downhill rapidly.

[benbucksch]

Ah, I didn't see that error message. Thanks. Then the cause and fix is clear: I need to run message.loadMIME() before opening it in the editor. I tried that and it works.

[benbucksch]

I've pushed the changes.

TODO: Draft does not get deleted on send, even though I try. There's something wrong with the message IDs, they don't match.

[benbucksch]

TODO: Draft does not get deleted on send, even though I try. There's something wrong with the message IDs, they don't match.

Filed #413 about that