-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZAP - KCWI #7
Comments
Hi, Lines 342 to 347 in ed07445
This could easily be fixed by adding a parameter to specify the HDU name or index. Do you know if there is some public data that I could use for a quick test ? |
Thanks for the quick reply, https://www.dropbox.com/sh/e5yirpylmimn7d4/AABnmc1MtxAYMK6809F8lRtIa?dl=0 _NOSKY variants are the cubes without the default KCWI sky subtraction [for my science I will probably look into doing filled field sky subtraction using offset sky frames]. Thanks for the help |
Thanks @gannonjs , I tried with your test cubes and added in the code a detection of the instrument in order to read and write to the correct extensions. Is it good to suppose that KCWI data are always in the primary HDU ? Otherwise I will need to add a keyword to specify the HDUs indices. So with this change (you can try the 'kwci' branch) it seems to work. I created quickly a mask for the edges, with null values, but to get better results the artifacts at the beginning and end of the cube should also be masked. Zap does not currently have an option to skip a given wavelength range, so the easy way to proceed for now would be give it a cropped cube, or a cube where these wavelengths are filled with NaNs. |
Thank you very much for how quickly you have helped me with this. I am only just starting to use KCWI so am unable to comment fully on supposing the KCWI data is in the primary HDU though I have put multiple different obs from different nights through the pipeline and each seems to run now so I suspect it is a fair assumption. I have run a few cropped cubes through ZAP now and am getting promising results. [though need to play around with the parameters more] |
Thanks for testing the branch. Let's go with this for now, we can still revisit how to load KCWI data in the future if needed. |
I'm currently looking at using your code ZAP on some KCWI data. Messing about with some test data I am running into problems where it seems the FITS header isn't being correctly parsed by the program [see below]. Do you know of anyone using ZAP for KCWI data?
It seems to be a problem with fits.open in astropy.io:
I realise that this may not be related to ZAP but will be grateful for any help you are able to provide.
The text was updated successfully, but these errors were encountered: