Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JS tests #9

Open
alwaysblank opened this issue Jul 5, 2020 · 2 comments
Open

Add JS tests #9

alwaysblank opened this issue Jul 5, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@alwaysblank
Copy link
Collaborator

Not adding this to the 2.0 milestone because the package is simple enough that I feel okay about no tests (and I have no experience writing JS testing, so it may be a long road), but tests should definitely be implemented to make future development/enhancement quicker and safer.

@alwaysblank alwaysblank added the enhancement New feature or request label Jul 5, 2020
@alwaysblank alwaysblank self-assigned this Jul 5, 2020
@alwaysblank
Copy link
Collaborator Author

I'm putting this on hold because I'm not quite sure how to proceed. The module relies very heavily on MutationObserver, which doesn't appear to be accurately replicated in Jest. I think the way forward is probably to switch over to Mocha, or something that will be running this stuff in an actual headless browser, but I'm not relishing the idea of re-writing the tests I've already written. It is a goal, and only I would ideally like to make at least some progress on before 2.0 release.

@alwaysblank
Copy link
Collaborator Author

FYI existing progress can be found on the tests, branch: https://github.com/murmurcreative/module-drawer/tree/tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant