Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/index: change 'session key' to something more understandable #146

Closed
globusharris opened this issue May 24, 2019 · 5 comments
Closed

/index: change 'session key' to something more understandable #146

globusharris opened this issue May 24, 2019 · 5 comments

Comments

@globusharris
Copy link

e.g. 'BWWC 2019 Analysis ID'.

Use handlebars for this so can change depending on deployment.

We discussed changing this to 'Company ID' and decided against this since it might signal to companies that they are identifiable by SAIL based on this ID.

@globusharris
Copy link
Author

Should match wording to this on /manage pages as well.

@lucyq
Copy link
Member

lucyq commented Jul 3, 2019

Should be generic and located somewhere in the config.

@globusharris
Copy link
Author

@lucyq yep that's how I've implemented. :)

@globusharris
Copy link
Author

Right now, handlebars only works in index.html due to server-side rendering. Working on expanding it to work for all html files now.

@lucyq lucyq mentioned this issue Jul 8, 2019
@lucyq
Copy link
Member

lucyq commented Jul 11, 2019

Closed by #163

@lucyq lucyq closed this as completed Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants