Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[useDialogs] Allow customizing dialogs.prompt, dialogs.alert and dialogs.confirm #4367

Open
prakhargupta1 opened this issue Nov 4, 2024 · 1 comment
Open

[useDialogs] Allow customizing dialogs.prompt, dialogs.alert and dialogs.confirm #4367

prakhargupta1 opened this issue Nov 4, 2024 · 1 comment
Labels
component: dialog This is the name of the generic UI component, not the React module! scope: toolpad-core Abbreviated to "core" status: waiting for maintainer These issues haven't been looked at yet by a maintainer

Comments

@prakhargupta1
Copy link
Member

prakhargupta1 commented Nov 4, 2024 •
edited by github-actions bot
Loading

Summary

The dialogs.open function accepts a React component and supports customization. A user requested the same support for dialogs.prompt

User request: https://discord.com/channels/1131323012554174485/1248515176626524200/1302895534054314035

Examples

No response

Motivation

No response

Search keywords: dialogs
@prakhargupta1 prakhargupta1 added status: waiting for maintainer These issues haven't been looked at yet by a maintainer scope: toolpad-core Abbreviated to "core" labels Nov 4, 2024
@oliviertassinari oliviertassinari changed the title [core] Allow customizing dialogs.prompt [toolpad-core] Allow customizing dialogs.prompt Nov 4, 2024
@bharatkashyap bharatkashyap changed the title [toolpad-core] Allow customizing dialogs.prompt [toolpad-core] Allow customizing dialogs.prompt, dialogs.alert and dialogs.confirm Nov 6, 2024
@bharatkashyap bharatkashyap changed the title [toolpad-core] Allow customizing dialogs.prompt, dialogs.alert and dialogs.confirm [useDialogs] Allow customizing dialogs.prompt, dialogs.alert and dialogs.confirm Nov 6, 2024
@oliviertassinari oliviertassinari added the component: dialog This is the name of the generic UI component, not the React module! label Nov 7, 2024
@Janpot
Copy link
Member

Janpot commented Dec 17, 2024

We could add slots to the DialogProvider for each of the system dialogs, and then export each of the system dialogs themselves so they can be customized. That way users can create their own system dialogs and set them as default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: dialog This is the name of the generic UI component, not the React module! scope: toolpad-core Abbreviated to "core" status: waiting for maintainer These issues haven't been looked at yet by a maintainer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Janpot @oliviertassinari @prakhargupta1