-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[experiments] Fully featured Menu + common infra #1330
[experiments] Fully featured Menu + common infra #1330
Conversation
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
When closing the menu shifts up and to the left by ~5-10px, causing a jitter? |
This is actually an effect of another issue: when I'll style the body element to fix the issue here. For the record - this is how it currently looks: Screen.Recording.2025-01-22.at.16.15.10.mov |
In order to fix #1343 on the |
It would prevent this exact problem, but all the other absolutely positioned elements on the page that only have statically positioned parents will be affected (they will shift when a popup opens and after it disappears), as in https://codesandbox.io/p/sandbox/headless-cloud-8s744f?file=%2Fsrc%2FApp.tsx%3A11%2C65. |
One option to prevent this from happening would be to teach developers to set up a positioning context on the |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Not super important, but the settings panel at the top left doesn't seem to be pre-rendered/SSR'd, and causes a layout shift on load |
It's defined in the experiment itself and portalled into the sidebar in the effect phase - that's why it appears slightly later. |
Add |
https://deploy-preview-1330--base-ui.netlify.app/experiments/menu/menu-fully-featured