Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Missing line on Composition page in "Composing multiple components" #1211

Closed
DanielGibbsNZ opened this issue Dec 22, 2024 · 2 comments · Fixed by #1212
Closed
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation regression A bug, but worse scope: docs-infra Specific to the docs-infra product

Comments

@DanielGibbsNZ
Copy link

Docs feedback

How can we improve Base UI documentation?

In the "Composing multiple components" section on the Composition page, there is a missing line that is not showing in the code example. The line is <Menu.Item render={<a href="base-ui.com" />}> (source here). Perhaps the prettier-ignore comment on the line above is causing it to be skipped somehow?

@github-actions github-actions bot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 22, 2024
@atomiks atomiks added docs Improvements or additions to the documentation and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Dec 22, 2024
@atomiks
Copy link
Contributor

atomiks commented Dec 22, 2024

It's not just that line it looks like. The entire page's code blocks have issues seemingly due to the prettier-ignore as you point out!

It appears to be a regression from #1187

Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

@DanielGibbsNZ How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work regression A bug, but worse scope: docs-infra Specific to the docs-infra product labels Dec 22, 2024
@oliviertassinari oliviertassinari changed the title [docs] Missing line on Composition page in "Composing multiple components" [docs-infra] Missing line on Composition page in "Composing multiple components" Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation regression A bug, but worse scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants