Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Software Regression #2

Open
Ooqu4 opened this issue Jan 23, 2019 · 0 comments
Open

Software Regression #2

Ooqu4 opened this issue Jan 23, 2019 · 0 comments

Comments

@Ooqu4
Copy link

Ooqu4 commented Jan 23, 2019

When trying to reproduce the results from the "Smashing Ethereum Smart Contracts for Fun and Real Profit" (v1.3) paper, I stumbled across a few regression issues:

Some module paths have been changed and the imports need to be adjusted:

  • mythril.ethereum.EVMContract.SolidityContract is now mythril.solidity.soliditycontract.SolidityContract

Throughout the paper the as_dict() function is used, which has been replaced
by a property decorator which means that the parentheses need to be omitted.

The following contracts in the contracts directory do not have a pragma solidity statement: assertions.sol, rubixi.sol, symvars.sol.

When generating CFGs (with myth -g), the resulting graphs look bigger than the given ones in the CFG folder. I assume this has to do with a divergent solc version.

It would be nice to have these small issues corrected, since they cost a bit of time to figure out.
Furthermore it would be good to annotate the used solc versions in order to be able to retrace the results precisely.

I haven't worked through the entire paper yet, so there may be more to come.

Apart from that, the paper is well written and good to understand.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant