Adding enhancement #131 - Student title vs. Instructor title #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mterwill
reviewed
Nov 25, 2019
| var myRequestIdx = this.state.requests.indexOf(myRequest.request); | ||
| document.title = `(#${myRequestIdx + 1}) Office Hours Help Queue` | ||
| } else { | ||
| document.title = `(${this.state.requests.length}) Office Hours Help Queue` |
There was a problem hiding this comment.
Thanks for putting this together! Thoughts on providing some indication as to whether or not we’re showing your request or the total queue size? Maybe (8/24) Office Hours Help Queue if you’re on the queue and (24) Office Hours Help Queue if not.
There was a problem hiding this comment.
Oh, 🤦♂ just realized you have a pound sign in there. That works for me!
mterwill
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the enhancement requested by issue #131 , and was made with Ram Natla (@ramnatla). If the logged-in user is currently on the queue, the title of the page is updated to show their position: "(#2) Office Hours Help Queue". If the logged-in user is not on the queue, the title will display the total number of people on the queue. For example, if 20 people were on the queue, the title will display: "(20) Office Hours Help Queue".
To implement this, any time the queue receives an update, the title of the page was dynamically changed.
We would appreciate any and all feedback on this PR!