Refactor request boxes #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract request box generation into a new method - Show pinned requests to students under the normal queue - Show requests pinned by other instructors under the normal queue
If a request is pinned, display who originally pinned the request as part of the request metadata. Closes #126
to allow popping people from the queue that are pinned by others. The pop order is now: pinned by you, not pinned, pinned by others, which mirrors the way it is displayed in the UI. Since the queue pop button can now pop up to $requests.length requests, this closes #98.
mterwill
force-pushed
the
request-boxes
branch
from
c2b9159 to
e133bd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #117
Closes #97