Undo Recent Pop Feature

[smikell]

There have been a couple of occasions where I accidentally pop/resolve a student when I mean to pin them. As such a quick, undo recent pop button would be a nice addition. Clicking the button would take the most recent student popped and place them back in the queue at their relative position (time elapsed since request). I'd love to contribute myself, but this is my first time seeing the codebase, so any tips on where to start?

[mterwill]

👋 hey @smikell! I like this idea. Instead of adding a new button, I'm curious how it would feel if the 'Pop' button briefly changed to 'Undo' after you clicked it. That button is rendered here:

office-hours-help-queue/app/assets/javascripts/components/instructor_panel.js.jsx

Line 64 in 7aa63f2

<Action data={this.getQueuePopButtonData()} />

Which calls this method on the backend:

office-hours-help-queue/app/channels/queue_channel.rb

Lines 99 to 105 in 8815e0b

	def queue_pop(data)
	authorize :instructor_only
	request = @course_queue.pop!(current_user)
	broadcast_request_change('resolve_request', request)
	end

Undoing a pop would be as simple as looking up the request and setting resolved_at and resolver back to null.

Perhaps we should update queue_pop to take in a request_id, so that the frontend only 'pops' the request it intended. You should then be able to store the 'last popped' request ID in component state for the instructor panel and pass it to a new method on the backend if Undo is clicked.