Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic HTML title #131

Closed
cyanliu-zzz opened this issue Mar 12, 2018 · 2 comments
Closed

Dynamic HTML title #131

cyanliu-zzz opened this issue Mar 12, 2018 · 2 comments

Comments

@cyanliu-zzz
Copy link

cyanliu-zzz commented Mar 12, 2018

This is just a tiny suggestion, but I think the title of the OH site could be made more dynamic to provide slightly more information at a glance. I was specifically thinking of something depicted in the image below

image

where the (1) would correspond to the number of people currently on the queue. I'm an IA for EECS398 where there could potentially be long stretches of time without any queue activity, and I don't always keep the OH queue open on my browser, but I do often have the tab in whatever my active window is.

I realize that most queues don't have this problem, but I'd imagine similarly styled bite-sized pieces of information in the tab could be useful for students as well. For example, if they wanted to know their position on the queue without opening the tab, maybe it could look like the following:

image

Thoughts?

@mterwill
Copy link
Owner

I think this is a great idea! It wouldn't be terribly difficult, either, as we have the current state of the queue in the main react component and you could hook into that and set document.title.

FWIW the queue is supposed to notify you if a new request comes in and you're not on that tab.

if (wasEmpty && isInactiveWindow && isInstructor) {
this.notify('New request from ' + request.requester.name, false, {
icon: request.requester.avatar_url,
body: request.description || request.location,
});

If there's an issue with that I'd love to get it fixed, too!

@cyanliu-zzz
Copy link
Author

cyanliu-zzz commented Mar 15, 2018

I admittedly didn't even realize that I had browser notifications disabled this whole time until after I made this suggestion, but yeah maybe there is some repetitive functionality happening here 😅 ...(that's definitely my bad)

But I'd imagine the queue position feature would be more feasible than creating estimated wait time...maybe...? I know that resolve timestamps are recorded, but I haven't poked around the code enough to check whether the "start" (?) time is recorded as well 😬

edit: oh yeah start times are recorded, hmm... this is starting to just look like a feature suggestion that's rather similar to #91 😅

mterwill added a commit that referenced this issue Nov 26, 2019
Adding enhancement #131 - Student title vs. Instructor title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants