Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: optional boto #106

Open
hydrapolic opened this issue Jun 19, 2020 · 1 comment
Open

Feature request: optional boto #106

hydrapolic opened this issue Jun 19, 2020 · 1 comment
Assignees
Milestone

Comments

@hydrapolic
Copy link

hydrapolic commented Jun 19, 2020

As of now, boto is a strict requirement and if I don't have the aws sdk installed cachet-url-monitor fails to start.

I have to manually remove:

cachet_url_monitor/plugins/token_provider.py:from boto3.session import Session
cachet_url_monitor/plugins/token_provider.py:from botocore.exceptions import ClientError

It would be nice for boto to become and optional dependency so that cachet-url-monitor would work even without the boto lib installed for those not using aws.

Thanks for this handy tool!

@mtakaki
Copy link
Owner

mtakaki commented Jun 25, 2020

That's a good suggestion. I'll have to split them into separate files, so you wouldn't hit that line when you're not using AWS.
I'll tag this for the next release.

Thanks for using this tool and for helping me make it better :)

@mtakaki mtakaki self-assigned this Jun 25, 2020
@mtakaki mtakaki added this to the 0.8.0 milestone Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants