New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass RNG as first argument #78

Open

cscherrer opened this issue May 11, 2021 · 1 comment

Contributor

cscherrer commented May 11, 2021

It would be helpful if methods like

pdmp(∇ϕ, x, θ, T, Flow::ContinuousDynamics; adapt=true,  factor=2.0)

could be replaced with

pdmp(rng::AbstractRNG, ∇ϕ, x, θ, T, Flow::ContinuousDynamics; adapt=true,  factor=2.0)

The standard approach is then to define

pdmp(∇ϕ, x, θ, T, Flow::ContinuousDynamics; adapt=true,  factor=2.0) = pdmp(GLOBAL_RNG, ∇ϕ, x, θ, T, Flow; adapt=adapt,  factor=factor)

so it wouldn't be a breaking change.

Owner

mschauer commented May 12, 2021

Yeah, planned. I already did half of the changes necessary for that 7c7b57f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment