error when building on arm64 MacBook #7

jwatte · 2021-12-22T04:23:39Z

Note that there exists a fix for building on M1:
google/cpu_features#211

Also, this module is broken. The cause of the breakage (upstream or not) doesn't really matter -- unless you're saying "I never plan on fixing this," keeping the issue open helps the community understand what's going on.

Finally, I predict this will become more of a pressing issue now that Apple has stopped selling x64 MacBook Pros entirely, AND this module is a dependency of the electron installer builders.

mscdex · 2021-12-22T04:33:20Z

I'm not keen on having to patch dependencies like this because I'm not familiar with the cpu_features codebase (let alone macs), so I'm not really qualified to say whether the changes in one PR or another is correct (there are multiple PRs now to add M1 support in cpu_features, all delayed for various reasons).

jwatte · 2021-12-22T04:44:05Z

That's fair, but I propose the issue is kept open until the problem no longer exists.
One way or another, the upstream will presumably pick one of the fixes ...

lxe · 2022-02-01T15:48:27Z

@mscdex looks like you've fixed all the build issues for M1 Macs, but I'm not seeing the new commits published to npm. Would you mind getting a new version out? Thanks!

starzou · 2022-02-22T10:35:36Z

@mscdex Hello, Are there new plans?

mscdex · 2022-02-22T10:55:31Z

AFAIK there is still no M1 support upstream. The only Apple-related fixes that I originally floated and were eventually made upstream (which I pulled in awhile back) were for macOS x86.

bompi88 · 2022-03-08T15:31:43Z

@mscdex A new version is now available: https://github.com/google/cpu_features/releases/tag/v0.7.0

technicalpickles · 2022-03-10T16:20:53Z

It took me a minute to realize the dependency is bundled in deps/cpu_features. I tried grabbing the tarball and replacing the directory, but it looks like it's more involved than that.

mscdex · 2022-03-17T01:52:13Z

I've landed cpu_features v0.7.0 in the master branch. Everyone feel free to give it a whirl and let me know how it works for you.

mscdex · 2022-03-24T04:33:19Z

I'm going to assume the aforementioned upgrade fixed things. If not, let me know.

ckortekaas · 2022-03-25T09:55:24Z

@mscdex I'm afraid after upgrading to ssh 1.8.0 which brings in cpu-features 0.3 I started getting "dyld missing symbol called" in my jest integration tests and webpack compilation. This is on a Macbook Pro M1 Max with MacOS 12.3 and Node 16.14.2. I'm happy to run any debug commands locally that might help. For now, I've pinned ssh back to 1.7.0. Thanks for your hard work on these libraries 🙇‍♂️

mscdex · 2022-03-25T12:04:23Z

@ckortekaas If you're getting them from ssh2, then please create an issue in that repo.

mscdex · 2022-03-25T18:48:19Z

If anyone here is getting those symbol errors while running the cpu-features tests, can you provide a backtrace (via gdb or lldb or similar) to show what the missing symbol is? You may need to switch from Release to Debug in lib/index.js and node-gyp --debug rebuild in order to see symbols and proper backtraces.

mscdex · 2022-03-25T18:52:44Z

FWIW I can't reproduce those errors on Github's infrastructure and I don't have any mac hardware myself to test on.

alexbosworth · 2022-03-25T18:58:30Z

I'm not sure if this helps but here is what I get in lldb

dyld[11400]: missing symbol called
Process 11400 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
    frame #0: 0x000000010490f4dc dyld`__abort_with_payload + 8
dyld`__abort_with_payload:
->  0x10490f4dc <+8>:  b.lo   0x10490f4fc               ; <+40>
    0x10490f4e0 <+12>: pacibsp 
    0x10490f4e4 <+16>: stp    x29, x30, [sp, #-0x10]!
    0x10490f4e8 <+20>: mov    x29, sp
Target 0: (node) stopped.

mscdex · 2022-03-25T19:05:15Z

@alexbosworth What does bt show?

alexbosworth · 2022-03-25T19:06:22Z

(lldb) bt
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
  * frame #0: 0x000000010490f4dc dyld`__abort_with_payload + 8
    frame #1: 0x00000001049164dc dyld`abort_with_payload_wrapper_internal + 104
    frame #2: 0x0000000104916510 dyld`abort_with_payload + 16
    frame #3: 0x00000001048ce8e4 dyld`dyld4::halt(char const*) + 328
    frame #4: 0x00000001048ecf7c dyld`dyld4::APIs::_dyld_missing_symbol_abort() + 44
    frame #5: 0x0000000104ad9278 cpufeatures.node`GetCPUInfo(info=0x000000016fdfe6a0) at binding.cc:117:31
    frame #6: 0x0000000104adb244 cpufeatures.node`Nan::imp::FunctionCallbackWrapper(info=0x000000016fdfe6f0) at nan_callbacks_12_inl.h:176:3
    frame #7: 0x0000000100270d78 node`v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo) + 276
    frame #8: 0x0000000100270870 node`v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments) + 468
    frame #9: 0x00000001002700fc node`v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) + 228
    frame #10: 0x00000001009b0bcc node`Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_BuiltinExit + 108
    frame #11: 0x0000000100944718 node`Builtins_InterpreterEntryTrampoline + 248
    frame #12: 0x0000000100944718 node`Builtins_InterpreterEntryTrampoline + 248
    frame #13: 0x0000000100944718 node`Builtins_InterpreterEntryTrampoline + 248
    frame #14: 0x0000000100944718 node`Builtins_InterpreterEntryTrampoline + 248
    frame #15: 0x0000000100944718 node`Builtins_InterpreterEntryTrampoline + 248
    frame #16: 0x0000000100944718 node`Builtins_InterpreterEntryTrampoline + 248
    frame #17: 0x0000000100944718 node`Builtins_InterpreterEntryTrampoline + 248
    frame #18: 0x000000010094250c node`Builtins_JSEntryTrampoline + 172
    frame #19: 0x00000001009421a4 node`Builtins_JSEntry + 164
    frame #20: 0x0000000100313d64 node`v8::internal::(anonymous namespace)::Invoke(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) + 2388
    frame #21: 0x00000001003133f8 node`v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Handle<v8::internal::Object>*) + 200
    frame #22: 0x0000000100220888 node`v8::Function::Call(v8::Local<v8::Context>, v8::Local<v8::Value>, int, v8::Local<v8::Value>*) + 520
    frame #23: 0x0000000100083f5c node`node::ExecuteBootstrapper(node::Environment*, char const*, std::__1::vector<v8::Local<v8::String>, std::__1::allocator<v8::Local<v8::String> > >*, std::__1::vector<v8::Local<v8::Value>, std::__1::allocator<v8::Local<v8::Value> > >*) + 104
    frame #24: 0x0000000100084fc0 node`node::StartExecution(node::Environment*, char const*) + 312
    frame #25: 0x0000000100084e6c node`node::StartExecution(node::Environment*, std::__1::function<v8::MaybeLocal<v8::Value> (node::StartExecutionCallbackInfo const&)>) + 1044
    frame #26: 0x0000000100005a1c node`node::LoadEnvironment(node::Environment*, std::__1::function<v8::MaybeLocal<v8::Value> (node::StartExecutionCallbackInfo const&)>) + 136
    frame #27: 0x00000001000ee580 node`node::NodeMainInstance::Run(int*, node::Environment*) + 72
    frame #28: 0x00000001000ee27c node`node::NodeMainInstance::Run(node::EnvSerializeInfo const*) + 120
    frame #29: 0x0000000100087080 node`node::Start(int, char**) + 184
    frame #30: 0x00000001048c90f4 dyld`start + 520

mscdex · 2022-03-25T19:14:24Z

Looks like cpu_features' support for M1 macs isn't complete then. 🤷‍♂️

So I guess if you want to see it fixed, continue to bug them about it/test for them over on their repo.

I guess something like this PR will fix things as that should resolve the undefined symbol issue. Whether or not additional changes are needed for reading the M1's CPU features compared to the existing solutions for arm64-based systems (e.g. Linux), I don't know.

alexbosworth · 2022-03-25T19:22:35Z

I guess something like this PR will fix things as that should resolve the undefined symbol issue. Whether or not additional changes are needed for reading the M1's CPU features compared to the existing solutions for arm64-based systems (e.g. Linux), I don't know.

Cool, yeah sounds like the problem derives from lack of support there and it seems like a fix is in progress

FabianFrank · 2022-03-30T03:30:13Z

Allegedly fixed in the latest release of cpu_features https://github.com/google/cpu_features/releases/tag/v0.7.0 with google/cpu_features#209

mscdex · 2022-03-30T03:52:24Z

@FabianFrank Unfortunately the support is not complete with v0.7.0.

alexbosworth · 2022-04-05T23:21:28Z

Seems like this issue went away for me when I updated to MacOS 12.3

mscdex · 2022-04-05T23:46:05Z

@alexbosworth The underlying problem still exists (M1 support doesn't actually exist in cpu_features), the only difference is that we now explicitly report the M1 as an unknown CPU without any feature flags instead of crashing at runtime.

alexbosworth · 2022-04-05T23:46:45Z

Ah great thanks

technicalpickles mentioned this issue Mar 7, 2022

Fix arm64 detection precedence in CMakeLists.txt google/cpu_features#209

Merged

technicalpickles mentioned this issue Mar 17, 2022

Remove cpu_features dependency mscdex/ssh2#1083

Closed

mscdex closed this as completed Mar 24, 2022

technicalpickles mentioned this issue Mar 24, 2022

Update ssh2 to a version whose dependencies build on M1 DataDog/datadog-ci#508

Merged

2 tasks

alexbosworth mentioned this issue Mar 25, 2022

Error "dyld[35932]: missing symbol called" on MacOS mscdex/ssh2#1146

Closed

alexbosworth mentioned this issue Mar 25, 2022

Missing support for M1 features google/cpu_features#236

Closed

Rugvip mentioned this issue Apr 5, 2022

Apple Silicon (M1) - backend won't start (dyld: missing symbol called) - After upgrading to 1.0.x backstage/backstage#10476

Closed

m-rousse mentioned this issue Apr 7, 2022

Tool fails in M1 intel machines DataDog/datadog-ci#514

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

error when building on arm64 MacBook #7

error when building on arm64 MacBook #7

jwatte commented Dec 22, 2021

mscdex commented Dec 22, 2021 •

edited

Loading

jwatte commented Dec 22, 2021

lxe commented Feb 1, 2022

starzou commented Feb 22, 2022

mscdex commented Feb 22, 2022

bompi88 commented Mar 8, 2022 •

edited

Loading

technicalpickles commented Mar 10, 2022

mscdex commented Mar 17, 2022

mscdex commented Mar 24, 2022

ckortekaas commented Mar 25, 2022

mscdex commented Mar 25, 2022

mscdex commented Mar 25, 2022 •

edited

Loading

mscdex commented Mar 25, 2022 •

edited

Loading

alexbosworth commented Mar 25, 2022

mscdex commented Mar 25, 2022

alexbosworth commented Mar 25, 2022

mscdex commented Mar 25, 2022 •

edited

Loading

alexbosworth commented Mar 25, 2022

FabianFrank commented Mar 30, 2022

mscdex commented Mar 30, 2022

alexbosworth commented Apr 5, 2022

mscdex commented Apr 5, 2022

alexbosworth commented Apr 5, 2022

error when building on arm64 MacBook #7

error when building on arm64 MacBook #7

Comments

jwatte commented Dec 22, 2021

mscdex commented Dec 22, 2021 • edited Loading

jwatte commented Dec 22, 2021

lxe commented Feb 1, 2022

starzou commented Feb 22, 2022

mscdex commented Feb 22, 2022

bompi88 commented Mar 8, 2022 • edited Loading

technicalpickles commented Mar 10, 2022

mscdex commented Mar 17, 2022

mscdex commented Mar 24, 2022

ckortekaas commented Mar 25, 2022

mscdex commented Mar 25, 2022

mscdex commented Mar 25, 2022 • edited Loading

mscdex commented Mar 25, 2022 • edited Loading

alexbosworth commented Mar 25, 2022

mscdex commented Mar 25, 2022

alexbosworth commented Mar 25, 2022

mscdex commented Mar 25, 2022 • edited Loading

alexbosworth commented Mar 25, 2022

FabianFrank commented Mar 30, 2022

mscdex commented Mar 30, 2022

alexbosworth commented Apr 5, 2022

mscdex commented Apr 5, 2022

alexbosworth commented Apr 5, 2022

mscdex commented Dec 22, 2021 •

edited

Loading

bompi88 commented Mar 8, 2022 •

edited

Loading

mscdex commented Mar 25, 2022 •

edited

Loading

mscdex commented Mar 25, 2022 •

edited

Loading

mscdex commented Mar 25, 2022 •

edited

Loading