Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for tags: Allow non-ASCII characters; allow tags anywhere in the line #203

Open
ThomasLandauer opened this issue Sep 9, 2018 · 0 comments

Comments

@ThomasLandauer
Copy link
Contributor

First of all: The idea to allow tags to organize TODO's is excellent! I've never seen this anywhere else.

A few ideas to improve tags:

  1. Currently, only ASCII characters are allowed in tags, which is a problem for certain languages (e.g. German). The reason is \w at https://github.com/mrodalgaard/atom-todo-show/blob/master/lib/todo-model.coffee#L66 which only accepts "word characters". However, this could be solved by making the regex-engine locale-sensitive - at least http://www.php.net/manual/en/regexp.reference.escape.php says so. Do you have an idea how this could be achieved?
    Or what about taking another approach and consider basically anything prefixed by # as a tag, something like #[^#\s\.,]+

  2. Is there a specific reason why tags are only allowed at the end of the line? More general: Is there any reference for the "tag" syntax you're using?
    If you would omit the $ from the regex, tags would be possible anywhere: "TODO: #object #profile do this"

  3. Minor: I sometimes add an URL to a TODO for later reference. If the URL contains an html anchor (like e.g. www.example.com/foo.html#bar ), the bar part is extracted as a tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant