Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate the possibility of using picomatch.scan instead of glob-parent #482

Open
mrmlnc opened this issue Jan 7, 2025 · 0 comments
Open

Comments

@mrmlnc
Copy link
Owner

mrmlnc commented Jan 7, 2025

Currently, fast-glob has two dependencies that can extract the base static directory from patterns.

Right now we are using glob-parent for this, which has not had new versions released for a long time and has several bugs (gulpjs/glob-parent#63, gulpjs/glob-parent#60).

The purpose of the issue is to make a decision:

  1. Switch to picomatch.scan instead of glob-parent without losing accuracy.
  2. Take the time to fix the issues of the glob-parent package.

Related issues on the fast-glob side:

  1. fastGlob("?/*") fails to match #380, cannot be fixed without changes in the glob-parent package.
  2. Strange behavior at Windows root dir like D:/ #375, can be fixed on your side with hacks.
  3. Inconsistent behavior with escaped single quotes & brace expansion #480, the second part of the issue involves removing escape characters from the pattern's base static part. A useful option is unescape', which is not present in the glob-parent` package.
  4. Escaping paths with backslashes in dir names #262, the base directory can be . for a\\/*.
@mrmlnc mrmlnc added this to the 5.0.0 milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant