Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intelligently wait until previous deletion has completed #50

Open
recursionbane opened this issue Jan 13, 2023 · 2 comments
Open

Intelligently wait until previous deletion has completed #50

recursionbane opened this issue Jan 13, 2023 · 2 comments

Comments

@recursionbane
Copy link

recursionbane commented Jan 13, 2023 •
edited
Loading

Thank you for this tool!
I am here to suggest an improvement.

The current iteration with timers between deletion cycles is somewhat clunky, and does not take machine performance and network latency into account.

Recommended change is to wait until the "Moving X images" prompt disappears from the DOM before attempting the next deletion cycle.
@recursionbane
Copy link
Author

I made some other changes like removing the limit of retries in this fork: https://github.com/recursionbane/google-photos-delete-tool

@mrishab
Copy link
Owner

mrishab commented Feb 11, 2023

Sounds amazing. Can you make a PR back into the project with this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@recursionbane @mrishab