Free GIL when running check_bytes_arrays_within_dist #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #23 Add GIL release in `check_bytes_arrays_within_dist` function. - Add `Py_BEGIN_ALLOW_THREADS` macro before the loop in `check_bytes_arrays_within_dist_wrapper` function in `hexhamming/python_hexhamming.cc`. - Add `Py_END_ALLOW_THREADS` macro after the loop in `check_bytes_arrays_within_dist_wrapper` function in `hexhamming/python_hexhamming.cc`. - Remove the in-loop return statement in `check_bytes_arrays_within_dist_wrapper` function in `hexhamming/python_hexhamming.cc`. - Add unit test `test_check_bytes_arrays_within_dist_gil` in `test/test_hexhamming.py` to verify the functionality of `check_bytes_arrays_within_dist` function with GIL released. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/mrecachinas/hexhamming/issues/23?shareId=XXXX-XXXX-XXXX-XXXX).
There was a problem hiding this comment.
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 suggestion.
Files not reviewed (1)
- hexhamming/python_hexhamming.cc: Language not supported
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
|
|
||
| def run_other_task(): | ||
| for _ in range(5): | ||
| print("Running other task") |
There was a problem hiding this comment.
[nitpick] The print statement is unnecessary for the test and could be removed to make the test cleaner.
Suggested change
| print("Running other task") | |
| for _ in range(5): | |
| time.sleep(0.1) |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23
Add GIL release in
check_bytes_arrays_within_distfunction.Py_BEGIN_ALLOW_THREADSmacro before the loop incheck_bytes_arrays_within_dist_wrapperfunction inhexhamming/python_hexhamming.cc.Py_END_ALLOW_THREADSmacro after the loop incheck_bytes_arrays_within_dist_wrapperfunction inhexhamming/python_hexhamming.cc.check_bytes_arrays_within_dist_wrapperfunction inhexhamming/python_hexhamming.cc.test_check_bytes_arrays_within_dist_gilintest/test_hexhamming.pyto verify the functionality ofcheck_bytes_arrays_within_distfunction with GIL released.