Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate used action's with: clause #56

Open
TWiStErRob opened this issue Jul 16, 2023 · 1 comment
Open

Validate used action's with: clause #56

TWiStErRob opened this issue Jul 16, 2023 · 1 comment
Labels
pr-welcome This would be a good fix/feature, but the maintainer isn't planning on doing the work

Comments

@TWiStErRob
Copy link
Contributor

TWiStErRob commented Jul 16, 2023

Following validation of existence of an action and tag, I think it would be awesome if the validator grabbed action.yml and validated the with: block for required values. This would allow us to detect typos or mis-configurations early, especially in workflow_call and similar situations. Similarly for workflow_call situations, the inputs: could be checked for required and type inconsistencies in the calling with: block.

Additionally there could be a warning emitted if the default matches a provided value, but this is probably controversial, so might be worth treating it as a separate issue/enhancement.

cc @award28 FYI

@mpalmer mpalmer added the pr-welcome This would be a good fix/feature, but the maintainer isn't planning on doing the work label Jul 17, 2023
@mpalmer
Copy link
Owner

mpalmer commented Jul 17, 2023

I wouldn't say no to a PR implementing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-welcome This would be a good fix/feature, but the maintainer isn't planning on doing the work
Projects
None yet
Development

No branches or pull requests

2 participants