Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests assume that error messages are always in English #1803

Open
ZZZank opened this issue Jan 26, 2025 · 0 comments
Open

Tests assume that error messages are always in English #1803

ZZZank opened this issue Jan 26, 2025 · 0 comments

Comments

@ZZZank
Copy link
Contributor

ZZZank commented Jan 26, 2025

Tests assumed that error messages are always in English, so when running tests in a system where system default language is not English, evaluations might fail:

org.junit.ComparisonFailure: `var a = 3` [MESSAGE] expected:<[missing ; after statement]> but was:<[在语句后面缺少 “;”]>
	at org.junit.Assert.assertEquals(Assert.java:117)
	at org.mozilla.javascript.tests.Bug789277Test.assertMessageEquals(Bug789277Test.java:453)
	at org.mozilla.javascript.tests.Bug789277Test.parserWithIdeErrorReporter_Reader_IdeMode(Bug789277Test.java:447)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

Adding an option that forces using en_us lang in message formatting should be enough for fixing this i guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant